Re: Review Request: Revert a commit that breaks TestDocumentLayout
"Robert Mathias Marmorstein" <[email protected]> Sun, 18 Mar 2012 04:59:14 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
--===============9146435563989394464==
Content-Type: multipart/alternative;
boundary="===============4876295939436905722=="
--===============4876295939436905722==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
> On March 17, 2012, 9:13 a.m., Thomas Zander wrote:
> > The change had to do with a right-to-left layout where +1 would not go =
to the visible right, but to the left.
> > =
> > If this fixes the unit test, then please commit. I'll make a note to f=
ind the case where the old code broke for and add a unit test for that one =
too, so a solution can be found for all items :)
Sounds good. I'll push it, then.
- Robert Mathias
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104272/#review11500
-----------------------------------------------------------
On March 17, 2012, 1:08 a.m., Robert Mathias Marmorstein wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104272/
> -----------------------------------------------------------
> =
> (Updated March 17, 2012, 1:08 a.m.)
> =
> =
> Review request for KOffice and Thomas Zander.
> =
> =
> Description
> -------
> =
> This one-line change seems to have broken the kword-frames-TestDocumentLa=
yout unit test. I don't know whether the behaviour of Qt has changed or if=
the cursorToX function simply doesn't work as expected, but the test passe=
s after reverting this change.
> =
> =
> Diffs
> -----
> =
> kword/part/frames/KWTextDocumentLayout.cpp fc5173d =
> =
> Diff: http://git.reviewboard.kde.org/r/104272/diff/
> =
> =
> Testing
> -------
> =
> Everything builds, compiles, runs, and passes the same unit tests (plus o=
ne more!) if we revert the change. However, it's possible that it's the te=
st that's wrong. I don't understand the layout algorithm well enough to kn=
ow for sure.
> =
> =
> Thanks,
> =
> Robert Mathias Marmorstein
> =
>
--===============4876295939436905722==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/104272/">http://git.revie=
wboard.kde.org/r/104272/</a>
</td>
</tr>
</table>
<br />
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; padd=
ing-left: 10px;">
<p style=3D"margin-top: 0;">On March 17th, 2012, 9:13 a.m., <b>Thomas Zand=
er</b> wrote:</p>
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The chang=
e had to do with a right-to-left layout where +1 would not go to the visibl=
e right, but to the left.
If this fixes the unit test, then please commit. I'll make a note to f=
ind the case where the old code broke for and add a unit test for that one =
too, so a solution can be found for all items :)</pre>
</blockquote>
</blockquote>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spac=
e: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sounds good=
. I'll push it, then.</pre>
<br />
<p>- Robert Mathias</p>
<br />
<p>On March 17th, 2012, 1:08 a.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KOffice and Thomas Zander.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style=3D"color: grey;"><i>Updated March 17, 2012, 1:08 a.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">This one-line change seems to have broken the kword-frames-T=
estDocumentLayout unit test. I don't know whether the behaviour of Qt =
has changed or if the cursorToX function simply doesn't work as expecte=
d, but the test passes after reverting this change.
</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Everything builds, compiles, runs, and passes the same unit =
tests (plus one more!) if we revert the change. However, it's possible=
that it's the test that's wrong. I don't understand the layou=
t algorithm well enough to know for sure.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>kword/part/frames/KWTextDocumentLayout.cpp <span style=3D"color: grey"=
>(fc5173d)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/104272/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4876295939436905722==--
--===============9146435563989394464==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
--===============9146435563989394464==--