Re: Review Request 7098: Updated Koffice application name and information after switching to calligra
"Ben Cooksley" <[email protected]> Fri, 11 Apr 2014 10:43:31 -0000
| Newsgroups | gmane.comp.kde.devel.koffice |
|---|---|
| Message-ID | <[email protected]> |
--===============7881095134938407218==
Content-Type: multipart/alternative;
boundary="===============8178607786061396540=="
--===============8178607786061396540==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7098/#review11086
-----------------------------------------------------------
This patch is fine - but the binary form submitted to Reviewboard is missing the images which this patch needs to be usable.
Can you please email me directly a binary patch which I can apply locally?
Thanks,
Ben
- Ben Cooksley
On March 29, 2014, 10:46 a.m., Yash Ladia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://svn.reviewboard.kde.org/r/7098/
> -----------------------------------------------------------
>
> (Updated March 29, 2014, 10:46 a.m.)
>
>
> Review request for KOffice and Ben Cooksley.
>
>
> Repository: kde
>
>
> Description
> -------
>
> I updated the office page and subpages as we have switched to Calligra. I have changed the following:
> KSpread is now Sheets
> Kivio is now Flow
> KPlato is now Plan
> KWord is now Words
> KPresenter is now Stage
>
> I also fixed the bug that some of these pages refered to KOffice by name, mailing list name and irc channel name, forum, etc.
> I have added the new screenshots from calligra.org. I have also renamed the icons in images folder to the new ones.
>
>
> Diffs
> -----
>
> trunk/www/sites/www/applications/apps/flow.json PRE-CREATION
> trunk/www/sites/www/applications/apps/flow_generated.json PRE-CREATION
> trunk/www/sites/www/applications/apps/kivio.json 1381202
> trunk/www/sites/www/applications/apps/kivio_generated.json 1381202
> trunk/www/sites/www/applications/apps/kplato.json 1381202
> trunk/www/sites/www/applications/apps/kplato_generated.json 1381202
> trunk/www/sites/www/applications/apps/kpresenter.json 1381202
> trunk/www/sites/www/applications/apps/kpresenter_generated.json 1381202
> trunk/www/sites/www/applications/apps/kspread.json 1381202
> trunk/www/sites/www/applications/apps/kspread_generated.json 1381202
> trunk/www/sites/www/applications/apps/kword.json 1381202
> trunk/www/sites/www/applications/apps/kword_generated.json 1381202
> trunk/www/sites/www/applications/apps/plan.json PRE-CREATION
> trunk/www/sites/www/applications/apps/plan_generated.json PRE-CREATION
> trunk/www/sites/www/applications/apps/sheets.json PRE-CREATION
> trunk/www/sites/www/applications/apps/sheets_generated.json PRE-CREATION
> trunk/www/sites/www/applications/apps/stage.json PRE-CREATION
> trunk/www/sites/www/applications/apps/stage_generated.json PRE-CREATION
> trunk/www/sites/www/applications/apps/words.json PRE-CREATION
> trunk/www/sites/www/applications/apps/words_generated.json PRE-CREATION
> trunk/www/sites/www/images/icons/flow_22.png UNKNOWN
> trunk/www/sites/www/images/icons/flow_48.png UNKNOWN
> trunk/www/sites/www/images/icons/kivio_22.png UNKNOWN
> trunk/www/sites/www/images/icons/kivio_48.png UNKNOWN
> trunk/www/sites/www/images/icons/kplato_22.png UNKNOWN
> trunk/www/sites/www/images/icons/kplato_48.png UNKNOWN
> trunk/www/sites/www/images/icons/kpresenter_22.png UNKNOWN
> trunk/www/sites/www/images/icons/kpresenter_48.png UNKNOWN
> trunk/www/sites/www/images/icons/kspread_22.png UNKNOWN
> trunk/www/sites/www/images/icons/kspread_48.png UNKNOWN
> trunk/www/sites/www/images/icons/kword_22.png UNKNOWN
> trunk/www/sites/www/images/icons/kword_48.png UNKNOWN
> trunk/www/sites/www/images/icons/plan_22.png UNKNOWN
> trunk/www/sites/www/images/icons/plan_48.png UNKNOWN
> trunk/www/sites/www/images/icons/sheets_22.png UNKNOWN
> trunk/www/sites/www/images/icons/sheets_48.png UNKNOWN
> trunk/www/sites/www/images/icons/stage_22.png UNKNOWN
> trunk/www/sites/www/images/icons/stage_48.png UNKNOWN
> trunk/www/sites/www/images/icons/words_22.png UNKNOWN
> trunk/www/sites/www/images/icons/words_48.png UNKNOWN
> trunk/www/sites/www/images/screenshots/flow.png UNKNOWN
> trunk/www/sites/www/images/screenshots/plan.png UNKNOWN
> trunk/www/sites/www/images/screenshots/sheets.png UNKNOWN
> trunk/www/sites/www/images/screenshots/stage.png UNKNOWN
> trunk/www/sites/www/images/screenshots/words.png UNKNOWN
>
> Diff: https://svn.reviewboard.kde.org/r/7098/diff/
>
>
> Testing
> -------
>
> Not tested.
> Unable to run this code on my local machine
>
>
> Thanks,
>
> Yash Ladia
>
>
--===============8178607786061396540==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://svn.reviewboard.kde.org/r/7098/">https://svn.reviewboard.kde.org/r/7098/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is fine - but the binary form submitted to Reviewboard is missing the images which this patch needs to be usable.
Can you please email me directly a binary patch which I can apply locally?
Thanks,
Ben</pre>
<br />
<p>- Ben Cooksley</p>
<br />
<p>On March 29th, 2014, 10:46 a.m. UTC, Yash Ladia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://svn.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KOffice and Ben Cooksley.</div>
<div>By Yash Ladia.</div>
<p style="color: grey;"><i>Updated March 29, 2014, 10:46 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I updated the office page and subpages as we have switched to Calligra. I have changed the following:
KSpread is now Sheets
Kivio is now Flow
KPlato is now Plan
KWord is now Words
KPresenter is now Stage
I also fixed the bug that some of these pages refered to KOffice by name, mailing list name and irc channel name, forum, etc.
I have added the new screenshots from calligra.org. I have also renamed the icons in images folder to the new ones.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not tested.
Unable to run this code on my local machine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/www/sites/www/applications/apps/flow.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/flow_generated.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/kivio.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kivio_generated.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kplato.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kplato_generated.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kpresenter.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kpresenter_generated.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kspread.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kspread_generated.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kword.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/kword_generated.json <span style="color: grey">(1381202)</span></li>
<li>trunk/www/sites/www/applications/apps/plan.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/plan_generated.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/sheets.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/sheets_generated.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/stage.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/stage_generated.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/words.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/applications/apps/words_generated.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/www/sites/www/images/icons/flow_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/flow_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kivio_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kivio_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kplato_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kplato_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kpresenter_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kpresenter_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kspread_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kspread_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kword_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/kword_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/plan_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/plan_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/sheets_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/sheets_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/stage_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/stage_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/words_22.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/icons/words_48.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/screenshots/flow.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/screenshots/plan.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/screenshots/sheets.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/screenshots/stage.png <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/www/sites/www/images/screenshots/words.png <span style="color: grey">(UNKNOWN)</span></li>
</ul>
<p><a href="https://svn.reviewboard.kde.org/r/7098/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8178607786061396540==--
--===============7881095134938407218==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
koffice-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/koffice-devel
--===============7881095134938407218==--