Re: [Kolab-devel] [PATCH 1/2] Close existing slapd instances before launching 389 setup

Hi Francesco,

slapd_pid_file is actually under /var/run/dirsrv/ only most of the time 
(for those that have not switched to /run tmpfs yet), and I would think 
that the name of 'slapd-kolab.pid' is actually subject to the instance 
name for any given dirsrv instance.

On 2013-08-03 19:33, Francesco Frassinelli wrote:
> ---
>  pykolab/setup/setup_ldap.py | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/pykolab/setup/setup_ldap.py b/pykolab/setup/setup_ldap.py
> index b54fb55..5d97bf2 100644
> --- a/pykolab/setup/setup_ldap.py
> +++ b/pykolab/setup/setup_ldap.py
> @@ -341,6 +341,13 @@ ServerAdminPwd = %(admin_pass)s
> 
>      log.info(_("Setting up 389 Directory Server"))
> 
> +    # Close existing instances
> +    slapd_pid_file = '/var/run/dirsrv/slapd-kolab.pid'
> +    if os.path.exists(slapd_pid_file):
> +        with open(slapd_pid_file, 'r') as slapd_pid:
> +            subprocess.Popen(['kill', slapd_pid.read().rstrip()])
> +        time.sleep(5)
> +
>      setup_389 = subprocess.Popen(
>              command,
>              stdout=subprocess.PIPE,

Kind regards,

Jeroen van Meeuwen

-- 
Systems Architect, Kolab Systems AG

e: vanmeeuwen at kolabsys.com
m: +44 74 2516 3817
w: http://www.kolabsys.com

pgp: 9342 BF08