Re: [Kolab-devel] Submitting changes to pykolab
Paul Boddie <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kolab |
|---|---|
| Message-ID | <201311230022.35453.paul__13048.0466447354$1385161555$gmane$org@boddie.org.uk> |
On Monday 18. November 2013 14.24.12 Jeroen van Meeuwen (Kolab Systems) wrote: > > You would typically create a ticket, if one does not already exist, and > attach the git-format-patch version of your patch. I've made tickets for the predictably trivial licence boilerplate patch, which can probably be applied at almost any time because the changes are unlikely to be affected by other changes, as well as a patch to change the coding style to resemble more mainstream Python conventions: https://issues.kolab.org/show_bug.cgi?id=2552 https://issues.kolab.org/show_bug.cgi?id=2554 I appreciate that the latter is likely to be disruptive without actually adding any functionality, so it probably isn't so attractive to apply, but I'll be basing further changes on that work because it is likely to make such further work easier for me. Please let me know if this is interesting. I have some patches in the pipeline to tidy various things, eliminate duplicated code, as well as doing some more contentious things like reducing usage of the exec statement which, although valid, can often be a bit worrying to encounter because it can introduce some awkward run-time bugs. Paul