Re: [Kolab-devel] XMPP integration in Kolab web client

On Wednesday 12. March 2014 11.19.45 Torsten Grote wrote:
> 
> On Tuesday 11 March 2014 19:12:23 Paul Boddie wrote:
> > They currently live here:
> > 
> > http://git.kolab.org/pykolab/log/?h=dev/boddie
> 
> Awesome, then they are already a lot closer to upstream! :)

I'll gladly offer assistance in getting them upstream, certainly.

> > On the subject of generic naming, I extended setup_imap.py to support
> > Dovecot  configuration, although there's definitely more work required to
> > make it a full Kolab component, I think.
> 
> Great! I didn't know you were also working on that.

Well, it seemed like a logical progression from looking at IMAP issues 
generally.

> Maybe for easier and faster merges it would be better not to have one
> unified dev branch that includes many features and refactoring, but
> separate feature branches, one for each single feature. This way, we could
> merge features in already step by step when they are ready and not have
> everything blocked by one huge hard to merge branch.
> 
> What do you think?

Yes, that's what I should have done for some things, I suppose. Things started 
out in a very tentative way and built up from there, but at the same time the 
later work couldn't have been done without building on the earlier work: 
there's relatively little concurrent activity, although I suppose I could have 
aggressively merged code between numerous separately maintained branches, but 
it was admittedly more fluid and ad-hoc than it might have been. (I'm also not 
a git "native" and thus needed some time to get familiar with how things are 
done.)

Ignoring general changes and fixes to the core library parts of the 
distribution, there are a few areas to consider:

A refactoring of the way that the tool collects commands and their options in 
order to present them to the user. This resulted in the creation of the 
pykolab.introspection module...

http://git.kolab.org/pykolab/tree/pykolab/introspection.py?h=dev/boddie

The introduction of common routines for managing services which were 
duplicated in an impromptu fashion in lots of places in the pykolab.setup 
modules...

http://git.kolab.org/pykolab/tree/pykolab/setup/services.py?h=dev/boddie

(If people don't want to merge anything else from me, I would at least hope 
that they adopt this.)

Quite a bit of tidying up of the existing pykolab.setup modules, partly taking 
advantage of those common routines, but also reconsidering things like how 
setup-kolab interacts with the user and whether it actually needs to, and 
supporting a mode where it doesn't do anything more than check to see if it 
needs running to set things up.

The extra modules and support for other software builds on the above, but in 
the case of Converse and ejabberd it is separate and needn't be incorporated 
at all. The Dovecot support could in principle be merged into the 
"unrefactored" code - it's just editing different configuration files - but it 
would make more sense to adopt the services module and the resulting changes 
first or at the same time.

As I noted above, I'm happy to offer advice or assistance around the 
incorporation of any or all of the above.

Paul