Re: Review Request 123489: Remove unnecessary k3listview includes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123489/#review79477
-----------------------------------------------------------



plugins/alias/aliaspreferences.cpp (line 191)
<https://git.reviewboard.kde.org/r/123489/#comment54310>

    additional whitespace change...
    
    please do not include whitespace changes into commit which doing something else
    
    if you want to remove additional spaces, please do it in separate commit.
    
    it is really hard to understand functionality of this because it is too big (due to that whitespace changes).
    
    please fix it before merging code.


- Pali Rohár


On apr. 24, 2015, 1:01 popoludní, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123489/
> -----------------------------------------------------------
> 
> (Updated apr. 24, 2015, 1:01 popoludní)
> 
> 
> Review request for Kopete and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> The following k3listview includes do not affect complilation and/or run of the kopete application.
> 
> 
> Diffs
> -----
> 
>   protocols/groupwise/ui/gwcontactproperties.cpp c383585d1744053ffd09ee04a0629661839526ea 
>   protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 
>   plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f 
>   plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 
>   plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 
>   kopete/contactlist/kopetestatusgroupviewitem.h e691e66c03cdd631c739875914f80403c5edebc7 
> 
> Diff: https://git.reviewboard.kde.org/r/123489/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran kopete shell application. No exceptions or warnings thrown.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel