Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review81595
-----------------------------------------------------------



plugins/texteffect/texteffectpreferences.cpp (line 149)
<https://git.reviewboard.kde.org/r/124094/#comment55929>

    better to use ++f



plugins/texteffect/texteffectpreferences.cpp (line 151)
<https://git.reviewboard.kde.org/r/124094/#comment55928>

    why don't add directly ret.appent(...->item(f)->text()) ?



plugins/texteffect/texteffectpreferences.cpp (line 184)
<https://git.reviewboard.kde.org/r/124094/#comment55930>

    currentItem no ? single selection



plugins/texteffect/texteffectpreferences.cpp (line 187)
<https://git.reviewboard.kde.org/r/124094/#comment55931>

    Remove loop currentItem



plugins/texteffect/texteffectpreferences.cpp (line 204)
<https://git.reviewboard.kde.org/r/124094/#comment55932>

    currentItem ?



plugins/texteffect/texteffectpreferences.cpp (line 232)
<https://git.reviewboard.kde.org/r/124094/#comment55933>

    fix indent


- Laurent Montel


On juin 19, 2015, 7:13 après-midi, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124094/
> -----------------------------------------------------------
> 
> (Updated juin 19, 2015, 7:13 après-midi)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Replace the K3ListBox classes with QListWidget.
> 
> 
> Diffs
> -----
> 
>   plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 
>   plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/124094/diff/
> 
> 
> Testing
> -------
> 
> Build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel