Re: GSoC History plugin
Joshua Joseph <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kopete |
|---|---|
| Message-ID | <CAKYNVbRdUsdtFpmtv-wbiYoPT9j5HBAnq99frT_FgsTqmCheGA@mail.gmail.com> |
On Wed, Jun 24, 2015 at 11:46 AM, Pali Rohár <[email protected]> wrote: > On Wednesday 24 June 2015 11:40:14 Joshua Joseph wrote: > > Hi > > > > On Mon, Jun 22, 2015 at 1:27 PM, Pali Rohár <[email protected]> > wrote: > > > > > > > > > > > > Then post your interface for review and comments. > > > > > > See it here: > > > https://github.com/josh-wambua/kopete/blob/database_helper/plugins/history3/databasehelper.h > > > > Ehm?? Wtf? > > class DatabaseHelper : public QObject { > ... > QList<Kopete::Message> search(Kopete::Contact *from); > QList<Kopete::Message> search(Kopete::Contact *to); > QList<Kopete::Message> search(Kopete::Contact *from, QDate date); > QList<Kopete::Message> search(Kopete::Contact *to, QDate date); > ... > }; > > Thought overloading search() would make it easier to work with. What do you suggest? -- > Pali Rohár > [email protected] > _______________________________________________ > kopete-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kopete-devel > -- Thanks, Joshua _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel