Re: API for history plugin

On Wed, Jun 24, 2015 at 3:14 PM, Pali Rohár <[email protected]> wrote:

> (now breaking email thread)
>
> On Wednesday 24 June 2015 14:23:52 Joshua Joseph wrote:
> > It is fixed now.
> >
>
> I do not thing so...
>
>   void logMessage(Kopete::Message *message, Kopete::Protocol *protocol,
> bool isGroup = false);
>
> Why are there protocol and isGroup variables?
>
>
>   QList<Kopete::Message> search(Kopete::Contact *contact, bool showFrom =
> true);
>
> Do you think that such function API describes for what is designed? And
> is easy to use? Have you tried to imagine some code which will use it?
>
> If I write something like that:
>
>   messages = history->search(account->myself(), true);
>
> Without deep knowledge of what method search is doing and how is
> implemented I have really no idea what will be to "messages" set.
>

Check it now, Pali.


>
> --
> Pali Rohár
> [email protected]
> _______________________________________________
> kopete-devel mailing list
> [email protected]
> https://mail.kde.org/mailman/listinfo/kopete-devel
>



-- 
Thanks,
Joshua

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel