Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

Hi Pali,

Yes you'd raised this issue earlier too. Forgive my absent mindedness.
I'll take a look and update the diff :)

Warm Regards.

Thanking You,
R.Harish Navnit
The Enigma <http://harishnavnit.wordpress.com>

On Thu, Jun 25, 2015 at 6:33 PM, Pali Rohár <[email protected]> wrote:

> On Thursday 25 June 2015 12:47:20 R.Harish  Navnit wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/124173/
> > -----------------------------------------------------------
> >
> > Review request for Kopete, Laurent Montel and Pali Rohár.
> >
> >
> > Repository: kopete
> >
> >
> > Description
> > -------
> >
> > Removing the K3ListViews, Q3ListViews and Q3ListViewItem classes from
> the groupwise protocol.
> >
> >
> > Diffs
> > -----
> >
> >   protocols/gadu/ui/gadusearch.ui
> 8b1ecc1898f74f49f3efcf2346241545ff876de1
> >   protocols/groupwise/ui/gwaddcontactpage.cpp
> be2ead4e8fd4b521cf11b70fe81afad8f27a9f01
> >   protocols/groupwise/ui/gwchatpropsdialog.cpp
> 7361241c6f6380338774315332530daa6fb3705f
> >   protocols/groupwise/ui/gwchatsearch.ui
> f7e95071f8b9cd8b2c3815306b4fed4ac2afeec8
> >   protocols/groupwise/ui/gwchatsearchdialog.cpp
> ae23311cafb8c318f2da671e0809bf0a57f4b373
> >   protocols/groupwise/ui/gwcontactproperties.h
> b0a68812dffbe618205c4528586d7799d71e9131
> >   protocols/groupwise/ui/gwcontactprops.ui
> 19425b934a018f614642d3d48599a1d532ee5def
> >   protocols/groupwise/ui/gwcustomstatus.ui
> bbd7e5052975810963bde1f84c3efdc9a7074769
> >   protocols/groupwise/ui/gwprivacydialog.cpp
> 95328c738a3d21556a598408cfadd4a8bbeda227
> >
> > Diff: https://git.reviewboard.kde.org/r/124173/diff/
> >
> >
> > Testing
> > -------
> >
> > Build succeeeds.
> >
> >
> > Thanks,
> >
> > R.Harish  Navnit
> >
>
> Hi!
>
> Just a quick note about your patches which removing KDE3/Qt3 code:
>
> Look also at CMakeLists.txt files and remove coresponding KDE3/Qt3
> defines ideally with linking with KDE3/Qt3 libraries...
>
> It is good that we do not need to include and use KDE3/Qt3 support
> headers, but if we are still linking with KDE3/Qt3 libraries it does not
> help us.
>
> This just create hidden dependency on KDE3/Qt3 support libraries
> because we do not see any KDE3/Qt3 includes in code, but linker still
> needs real libraries...
>
> --
> Pali Rohár
> [email protected]
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel