Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 19:19:18 R.Harish Navnit wrote:
> On Thu, Jun 25, 2015 at 7:06 PM, Pali Rohár <[email protected]> wrote:
> 
> >
> > If there are errors it means that there are more calls to KDE3/Qt3
> > functions... Not all KDE3/Qt3 methods are in headers prefixed with
> > K3/Q3. This is reason why I wrote you to look at compiler defines and
> > linker flags
> >
> Okay. There is however a small problem in doing so.
> 
> The way I'm setting about removing these k3 classes, is by removing a
> certain k3/q3 class from a protocol/plugin etc, and then checking build.
> I'm trying to remove all occurrences of these k3/q3 classes one at a time.
> For eg, in the groupwise, I've removed k3/q3listviews first. However, there
> are still some k3 classes like k3listbox etc. So when I remove the support
> libraries from the CMakeLists.txt, the build would definitely fail, no ?
> 

Yes, build will fail.

> So, in order to avoid this, I'm thinking of removing all visible k3/q3
> occurrences first, from a protocol/plugin and then test again after
> removing the support libs. What do you say ?
> 

Sounds good. Do not remember that some defines enable additional
KDE3/Qt3 member methods. So once you remove defines some other code does
not have to compile... You need to port those methods too!

> 
> Warm Regards.
> 
> Thanking You,
> R.Harish Navnit
> The Enigma <http://harishnavnit.wordpress.com/>

-- 
Pali Rohár
[email protected]
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel