Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

"Laurent Montel" <[email protected]>
Newsgroups gmane.comp.kde.devel.kopete
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82267
-----------------------------------------------------------



plugins/texteffect/texteffectpreferences.cpp (line 204)
<https://git.reviewboard.kde.org/r/124094/#comment56646>

    you want to take currentitem no ?
    so why to get item from listWidget()->row(i) ?


- Laurent Montel


On juin 21, 2015, 11:41 matin, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124094/
> -----------------------------------------------------------
> 
> (Updated juin 21, 2015, 11:41 matin)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Replace the K3ListBox classes with QListWidget.
> 
> 
> Diffs
> -----
> 
>   plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 
>   plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/124094/diff/
> 
> 
> Testing
> -------
> 
> Build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.