Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

> On July 9, 2015, 6 p.m., Laurent Montel wrote:
> > plugins/texteffect/texteffectpreferences.cpp, line 204
> > <https://git.reviewboard.kde.org/r/124094/diff/5/?file=380817#file380817line204>
> >
> >     you want to take currentitem no ?
> >     so why to get item from listWidget()->row(i) ?

My reasoning was because the return value/type of QListWidget::row(int ) matches QListWidget::takeItem(int ) function's argument type and because it was easier to manipulate from a QListWidgetItem. Of course, now I think QListWidget::currentRow() would've sufficed ?


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82267
-----------------------------------------------------------


On June 21, 2015, 5:11 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124094/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 5:11 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Replace the K3ListBox classes with QListWidget.
> 
> 
> Diffs
> -----
> 
>   plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 
>   plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/124094/diff/
> 
> 
> Testing
> -------
> 
> Build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel