Re: Review Request 124227: Remove Q3ListViews from autoreplace
"Laurent Montel" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kopete |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124227/#review82643
-----------------------------------------------------------
plugins/autoreplace/autoreplacepreferences.cpp (line 49)
<https://git.reviewboard.kde.org/r/124227/#comment56995>
why it's better ?
you know how many column you added.
=> so not necessary to recalculate the number of column.
- Laurent Montel
On juil. 19, 2015, 12:15 après-midi, R.Harish Navnit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124227/
> -----------------------------------------------------------
>
> (Updated juil. 19, 2015, 12:15 après-midi)
>
>
> Review request for Kopete, Laurent Montel and Pali Rohár.
>
>
> Repository: kopete
>
>
> Description
> -------
>
> Replace the Q3ListView classes with QTreeWidgets.
>
>
> Diffs
> -----
>
> plugins/autoreplace/autoreplacepreferences.cpp dab6645f0552e6066ae8da09a35654d7dbaca8db
> plugins/autoreplace/autoreplaceprefs.ui 034013d41f90dd3d2e4c1e2dc94a0fbded8a7782
>
> Diff: https://git.reviewboard.kde.org/r/124227/diff/
>
>
> Testing
> -------
>
> Build Succeeds.
>
>
> Thanks,
>
> R.Harish Navnit
>
>
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel