Re: Review Request 124344: Replace k3activelabel classes with QLabel in libkopete

> On July 15, 2015, 10:08 a.m., Laurent Montel wrote:
> > When I read doc I see:
> >   * @deprecated Use QLabel. (QLabel::setOpenExternalLinks(true) for labels with hyperlinks;
> >   * QLabel::setTextInteractionFlags(Qt::TextSelectableByMouse|Qt::TextSelectableByKeyboard) for labels whose text
> >   * should be selectable by user.)
> > 
> > But you replace just by QLabel it's normal ?

Uhm sorry, I was following the Qt-assistant document, somehow missed this. Later found it out in https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/raw/KDE4PORTING.html


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124344/#review82517
-----------------------------------------------------------


On July 14, 2015, 12:34 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124344/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 12:34 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Use QLabel instead of K3ActiveLabel
> 
> 
> Diffs
> -----
> 
>   libkopete/ui/addressbookselectorwidget.cpp d1686ed855a94ee5a01db8a4ed0c04d573cd5be4 
>   libkopete/ui/addressbookselectorwidget_base.ui de6ec4d24cd10eebfebc11b4fb9839be206552dc 
>   libkopete/ui/metacontactselectorwidget.cpp 6a45cf2ac9f6d904e7f7363d2fb7e7306f0c6c3a 
>   libkopete/ui/metacontactselectorwidget_base.ui 1f69a48c559ab3f002700068ec6a6c200a9242e3 
> 
> Diff: https://git.reviewboard.kde.org/r/124344/diff/
> 
> 
> Testing
> -------
> 
> Build succeeded.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel