Re: NO_CAST policy for new kopete code

On 20 July 2015 at 15:45, Pali Rohár <[email protected]> wrote:

> Hello,
>
> I would be happy if Kopete could be compiled with defines:
>
>  -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII
>
> It disables automatic conversion between C strings char* (which are in
> unknown/any encoding) and QString (which is unicode). It prevents that
> mess of 8bit encodings (Utf-8, Latin1, ...) and ensure that caller
> correctly specify encoding of/for C char* strings.
>
> See more on:
>
>
> http://doc.qt.io/qt-4.8/qstring.html#converting-between-8-bit-strings-and-unicode-strings
>
> I know it is hard to fix all Kopete code to compiles with above NO_CAST
> flags, but what about policy to enforce that flags for all new code?
>
>
Sounds good.
+1 from my side.

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel