Re: Review Request 124094: Do away with K3ListBox classes texteffect plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124094/#review82820
-----------------------------------------------------------



plugins/texteffect/texteffectpreferences.cpp (line 160)
<https://git.reviewboard.kde.org/r/124094/#comment57136>

    Definition of K3ListBox::insertItem from http://doc.qt.io/qt-4.8/q3listbox.html#insertItem-3:
    
    void Q3ListBox::insertItem(const QString & text, int index = -1)
    
    Inserts a new list box text item with the text text into the list at position index. If index is negative, text is inserted at the end of the list.
    
    Definition of QListWidget::insertItem from http://doc.qt.io/qt-4.8/qlistwidget.html#insertItem-2
    
    void QListWidget::insertItem(int row, const QString & label)
    
    Inserts an item with the text label in the list widget at the position given by row.
    
    So for me it looks like your code is incorrect. If not, show me proof.



plugins/texteffect/texteffectpreferences.cpp (line 186)
<https://git.reviewboard.kde.org/r/124094/#comment57138>

    Is not QListWidget::removeItemWidget(i) doing same? Please check if yes/no.



plugins/texteffect/texteffectprefs.ui (line 85)
<https://git.reviewboard.kde.org/r/124094/#comment57139>

    Some whitespace TAB/spacing problem


- Pali Rohár


On júl 10, 2015, 2:54 popoludní, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124094/
> -----------------------------------------------------------
> 
> (Updated júl 10, 2015, 2:54 popoludní)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Replace the K3ListBox classes with QListWidget.
> 
> 
> Diffs
> -----
> 
>   plugins/texteffect/texteffectpreferences.cpp 35fac60d419cbac5644a8e143be1fc7c640385a9 
>   plugins/texteffect/texteffectprefs.ui 1b82f3de4b449373a3dedb39b664c0f645f1d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/124094/diff/
> 
> 
> Testing
> -------
> 
> Build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel