Re: Review Request 124305: Remove K3 classes from kopete main application

Pali Rohár <[email protected]>
Newsgroups gmane.comp.kde.devel.kopete
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124305/#review83712
-----------------------------------------------------------



kopete/chatwindow/chatview.cpp (line 995)
<https://git.reviewboard.kde.org/r/124305/#comment57934>

    Why is !Q3UriDrag::canDecode(event) changed do event->mimeData()->hasText() ?



kopete/contactlist/kopeteaddrbookexport.cpp (line 177)
<https://git.reviewboard.kde.org/r/124305/#comment57935>

    Who will free this object?


- Pali Rohár


On júl 26, 2015, 9:19 dopoludnia, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124305/
> -----------------------------------------------------------
> 
> (Updated júl 26, 2015, 9:19 dopoludnia)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Removes all occurences of the K3ListBox classes in the kopete main application.
> 
> 
> Diffs
> -----
> 
>   kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 
>   kopete/contactlist/kopeteaddrbookexport.h 4774ba8efe89cea5282a9566ec685a913012cece 
>   kopete/contactlist/kopeteaddrbookexport.cpp 8f285bf23dcad7336bd05b2697a300e983ceca73 
>   kopete/contactlist/kopeteaddrbookexportui.ui ec6ec9bc5c693b6df06499062defd1865a0a9c4f 
>   kopete/contactlist/kopetestatusgroupviewitem.h fb4a20648e1b12d464e98c51b8638f7d618ef53f 
>   kopete/contactlist/kopetestatusgroupviewitem.cpp 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 
> 
> Diff: https://git.reviewboard.kde.org/r/124305/diff/
> 
> 
> Testing
> -------
> 
> Build succeeded.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.