Re: Review Request 124691: Port K3Socketbase class in libkyahoo to qt4
Pali Rohár <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kopete |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124691/#review84057
-----------------------------------------------------------
protocols/yahoo/libkyahoo/client.cpp (line 1)
<https://git.reviewboard.kde.org/r/124691/#comment58225>
This looks like incomplete patch which do nothing. I do not want to include some generic Qt socket strings into kopete code. Socket error message from QAbstractSocket can be read by some Qt function.
- Pali Rohár
On aug. 19, 2015, 9:14 dopoludnia, R.Harish Navnit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124691/
> -----------------------------------------------------------
>
> (Updated aug. 19, 2015, 9:14 dopoludnia)
>
>
> Review request for Kopete and Laurent Montel.
>
>
> Repository: kopete
>
>
> Description
> -------
>
> Replace the k3socketbase class with QAbstractSocket
>
>
> Diffs
> -----
>
> protocols/yahoo/libkyahoo/client.cpp 1f94219e59928c7a1e6a96b1f91d67779fe0a044
>
> Diff: https://git.reviewboard.kde.org/r/124691/diff/
>
>
> Testing
> -------
>
> Build succeeds.
>
>
> Thanks,
>
> R.Harish Navnit
>
>
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel