Re: Review Request 124691: Port K3Socketbase class in libkyahoo to qt4

> On aug. 19, 2015, 6:31 popoludní, Pali Rohár wrote:
> > protocols/yahoo/libkyahoo/client.cpp, line 1
> > <https://git.reviewboard.kde.org/r/124691/diff/2/?file=396319#file396319line1>
> >
> >     This looks like incomplete patch which do nothing. I do not want to include some generic Qt socket strings into kopete code. Socket error message from QAbstractSocket can be read by some Qt function.
> 
> R.Harish  Navnit wrote:
>     The aim was to remove the occurences of k3socketbase classes and I instead used QAbstractSocket. I'll look again if there's some Qt function which can read the socket error messages.

But removing one include file k3socketbase.h from one source file does not achive it...


- Pali


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124691/#review84057
-----------------------------------------------------------


On aug. 19, 2015, 9:14 dopoludnia, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124691/
> -----------------------------------------------------------
> 
> (Updated aug. 19, 2015, 9:14 dopoludnia)
> 
> 
> Review request for Kopete and Laurent Montel.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Replace the k3socketbase class with QAbstractSocket
> 
> 
> Diffs
> -----
> 
>   protocols/yahoo/libkyahoo/client.cpp 1f94219e59928c7a1e6a96b1f91d67779fe0a044 
> 
> Diff: https://git.reviewboard.kde.org/r/124691/diff/
> 
> 
> Testing
> -------
> 
> Build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel