Re: Review Request 124345: Use treeWidgets instead of listviews in libkopete accountSelector

> On Sept. 3, 2015, 12:08 p.m., Pali Rohár wrote:
> > libkopete/ui/accountselector.cpp, line 100
> > <https://git.reviewboard.kde.org/r/124345/diff/6/?file=400086#file400086line100>
> >
> >     Are you sure that setHeaderLabel() is equivalent to addColumn?

I see from the doc that QTreeWidget::setHeaderLabel(const QString &label) is the same as QTreeWidget::setHeaderLabels(const QStringList &labels) - which "Adds a column in the header for each item in the labels list, and sets the label for each column". 
=> Adds a column, sets the label(header) for the column. Sounds sane to me, something wrong ?


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124345/#review84777
-----------------------------------------------------------


On Sept. 2, 2015, 4:04 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124345/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 4:04 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Replace K3ListViews/Q3ListViews with QTreeWidget classes.
> 
> 
> Diffs
> -----
> 
>   libkopete/ui/accountselector.h ff42a881f9151fe3b4db175577807fa191351467 
>   libkopete/ui/accountselector.cpp e6d5ee5f788cbc7606be25d8a9e3aff9b4866468 
> 
> Diff: https://git.reviewboard.kde.org/r/124345/diff/
> 
> 
> Testing
> -------
> 
> Build Succeeded.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel