Re: Review Request 124349: Remove kde3 dependencies from gadu protocol

> On July 15, 2015, 10:13 a.m., Laurent Montel wrote:
> > protocols/gadu/gadueditcontact.cpp, line 111
> > <https://git.reviewboard.kde.org/r/124349/diff/1/?file=385399#file385399line111>
> >
> >     So item which is not selectable and disable ?
> 
> R.Harish  Navnit wrote:
>     The default value for flags is { Qt::ItemIsSelectable | Qt::ItemIsUserCheckable | Qt::ItemIsEnabled | Qt::ItemIsDragEnabled }. That works better perhaps. Is that what you're saying ?
> 
> Laurent Montel wrote:
>     yep but you change flags you don't have new feature you assign just to ItemIsUserCheckable

I'm not sure I understood your initial comment here. Were you asking about items that are not selectable and disabled ? In that case setting the flag to Qt::ItemIsCheckable is pointless, yes. right ? 

In the patch for this, I have done something like this : 

```C++
if (item->isDisabled())
    item->setFlags(Qt::ItemIsUserCheckable);
```

Is that enough ?


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124349/#review82519
-----------------------------------------------------------


On July 14, 2015, 11:37 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124349/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 11:37 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Q3WidgetStack, Q3ButtonGroup, Q3ListViews and other classes removed.
> 
> 
> Diffs
> -----
> 
>   protocols/gadu/CMakeLists.txt b6da7736c94a1174b507aac3055b88c76da6aec2 
>   protocols/gadu/gaduaddcontactpage.cpp e55bd301b2bf4a6205c88b02c798b0094ceced5f 
>   protocols/gadu/gadueditaccount.cpp 20635e38b1bb4a99d220830747cc48731c7ccc63 
>   protocols/gadu/gadueditcontact.h 6b93fa3d84f7e54ec7ca3269f423e3b29e117449 
>   protocols/gadu/gadueditcontact.cpp 7475a4954173da0e9aac657cf90f4a3d2986bb4a 
>   protocols/gadu/gadupubdir.cpp c264519c44aa273039f0acb664e1a5df90b1640f 
>   protocols/gadu/gadusession.h 401a8eb16acf8e3263d20a36cd14b7eeb393783e 
>   protocols/gadu/ui/gaduadd.ui fdbe4a63fe1336095479b8f690a039e1652e7195 
>   protocols/gadu/ui/gadusearch.ui 3011347434e10205a390adf872a6a80077afb6b2 
> 
> Diff: https://git.reviewboard.kde.org/r/124349/diff/
> 
> 
> Testing
> -------
> 
> Build succeeded.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel