Re: Review Request 124181: Remove the K3Listbox and remaining K3 classes from groupwise

"R.Harish Navnit" <[email protected]>
Newsgroups gmane.comp.kde.devel.kopete
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124181/#review90538
-----------------------------------------------------------



protocols/groupwise/ui/gwprivacydialog.cpp (line 277)
<https://git.reviewboard.kde.org/r/124181/#comment61889>

    There's an obvious typo here, which I've fixed locally, but for some reason reviewboard doesn't pick it up. Here's the actual diff : http://ix.io/n9n


- R.Harish  Navnit


On Jan. 4, 2016, 5:50 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124181/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 5:50 p.m.)
> 
> 
> Review request for Kopete and Laurent Montel.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Remove the K3ListBox and needless includes from groupwise.
> 
> 
> Diffs
> -----
> 
>   protocols/groupwise/gwconnector.cpp d1330ad824dc7c731dc37a95b8735273c4890a46 
>   protocols/groupwise/ui/gwchatprops.ui f93fb5db8269323d5b28bd60181bbe3a209f80e3 
>   protocols/groupwise/ui/gwchatpropsdialog.cpp 5226bb3959439e0c954c7416c10ce839988f8d2e 
>   protocols/groupwise/ui/gwprivacy.ui 34fc4e41a669994d90e0fd2de218367d4e2917ea 
>   protocols/groupwise/ui/gwprivacydialog.h 595a031de6383ea27e9b2d54e270044b4e715cf2 
>   protocols/groupwise/ui/gwprivacydialog.cpp 3b2210f6907d29931de50e27f299fa67b6c7fdc6 
> 
> Diff: https://git.reviewboard.kde.org/r/124181/diff/
> 
> 
> Testing
> -------
> 
> Build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.