Re: Review Request 129325: Fix build with mediastreamer >= 2.14

> On Nov. 3, 2016, 7:32 nachm., Pali Rohár wrote:
> > Can you point to documentation or description of that changed function API? Or e.g. to sources?

Unfortunately the official online source is broken (as is the online git browser), but I found a mirror on github.
This is the commit that introduced the API break: https://github.com/BelledonneCommunications/mediastreamer2/commit/483fcd85d98ffdf220e37195575c6dd8209e7d6b#diff-3f018531208181605f23c3477ebcda86

I guess it has to be a MSFactory*, acquired by calling ms_factory_new_with_voip() during initialization.


- Fabian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129325/#review100543
-----------------------------------------------------------


On Nov. 3, 2016, 6:01 nachm., Fabian Vogt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129325/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 6:01 nachm.)
> 
> 
> Review request for Kopete.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> The API changed with mediastreamer 2.14, so introduce new global defines
> to support both the new and the old API.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindMediastreamer.cmake 47fe5c3 
>   protocols/jabber/libjingle/CMakeLists.txt 7ea8c3e 
>   protocols/jabber/libjingle/talk/session/phone/linphonemediaengine.cc bd3de2b 
> 
> Diff: https://git.reviewboard.kde.org/r/129325/diff/
> 
> 
> Testing
> -------
> 
> It builds. I'm not sure whether passing NULL as first parameter works, it might just crash.
> 
> 
> Thanks,
> 
> Fabian Vogt
> 
>