Re: Regarding old review requests for kopete on git reviewsboard
Pali Rohár <[email protected]> Mon, 6 Mar 2017 00:37:38 +0100
| Newsgroups | gmane.comp.kde.devel.kopete |
|---|---|
| Message-ID | <201703060037.38640@pali> |
On Monday 06 March 2017 00:32:41 vijay krishnavanshi wrote: > Hi, > > I looked around the old review requests of kopete on git reviewboard. > What needs to be done with review requests that are open. Hi! Basically every open pull request on reviewboard has review comments which needs to be fixed. If you are unsure what is problem with particular pull request, just ask exact question about it. > Do I need to apply the patches according to the reviews or something > else? Just download patch and apply it on top of kopete master branch... Also you should be able to find particular commits in kf5 branch from which reviewboard pull requests are created. -- Pali Rohár [email protected]
signature.asc
(application/pgp-signature, 198 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAli8oUIACgkQi/DJPQPkQ1IO4ACgvb8BUcLaEZQNnKxkUIqHC3jM mF4AoL8RYuLrWlC3oDWSXPAq7MsMI5wO =+TG+ -----END PGP SIGNATURE-----