Re: Review Request 130154: Re-enable XML-based history plugin, fix history file saving

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130154/#review103301
-----------------------------------------------------------



Looks good for me. @Montel if you do not see any obvious error, can it be committed/merged into kf5 branch?

- Pali Rohár


On jún 10, 2017, 4:47 popoludní, Paulo Lieuthier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130154/
> -----------------------------------------------------------
> 
> (Updated jún 10, 2017, 4:47 popoludní)
> 
> 
> Review request for Kopete and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> The history plugin port was not completed, so it is disabled. This patch re-enables it, fixes it's building failures and fixes not saving the history file when the directory doesn't exist.
> 
> Pull from here: https://github.com/paulolieuthier/kopete/commits/fix-history-plugin.
> 
> 
> Diffs
> -----
> 
>   libkopete/ui/kopeteview.h 070a3b8a2 
>   plugins/CMakeLists.txt 6216058ef 
>   plugins/history/CMakeLists.txt ce90b84a3 
>   plugins/history/converter.cpp 3175beac1 
>   plugins/history/historyguiclient.cpp 41745bfe0 
>   plugins/history/historylogger.cpp 66b627030 
>   plugins/history/historyplugin.cpp 48cd98010 
>   plugins/history/historypreferences.cpp 9c64b4418 
> 
> Diff: https://git.reviewboard.kde.org/r/130154/diff/
> 
> 
> Testing
> -------
> 
> Tested last messages appearance on reopening a chat window, using Jabber and Test Protocol.
> 
> 
> Thanks,
> 
> Paulo Lieuthier
> 
>