Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130155/#review103332
-----------------------------------------------------------




tests/libkopete/kopetepropertytemplatetest.cpp (line 84)
<https://git.reviewboard.kde.org/r/130155/#comment68740>

    use different string it's better



tests/libkopete/kopetestatusgrouptest.cpp (line 36)
<https://git.reviewboard.kde.org/r/130155/#comment68741>

    same string here. Cache value
    
    Remove space before after ->
    
    use QStringLiteral



tests/libkopete/kopetestatustest.cpp (line 43)
<https://git.reviewboard.kde.org/r/130155/#comment68742>

    remove space before/after ->
    
    use QStringLiteral etc.


- Laurent Montel


On June 17, 2017, 9:03 a.m., Vijay Krishnavanshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130155/
> -----------------------------------------------------------
> 
> (Updated June 17, 2017, 9:03 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> These autotests cover following classes - 
> - Kopete::PropertyTemplate
> - Kopete::StatusGroup
> - Kopete::Status::Status
> - Kopete::PropertyContainer
> - Kopete::Property
> 
> 
> Diffs
> -----
> 
>   tests/libkopete/CMakeLists.txt 236284b 
>   tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION 
>   tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION 
>   tests/libkopete/kopetepropertytest.cpp PRE-CREATION 
>   tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION 
>   tests/libkopete/kopetestatustest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/130155/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vijay Krishnavanshi
> 
>