Re: Review Request 130161: Replace KDebug by Qt's categorical logging in Kopete's protocols

Laurent Montel <[email protected]> Mon, 19 Jun 2017 04:51:33 -0000
Newsgroups	gmane.comp.kde.devel.kopete
Message-ID	<[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130161/#review103341
-----------------------------------------------------------




protocols/gadu/gaduaccount.cpp (line 284)
<https://git.reviewboard.kde.org/r/130161/#comment68755>

    it's not debug categories changes no ?:)



protocols/gadu/gaduaccount.cpp (line 321)
<https://git.reviewboard.kde.org/r/130161/#comment68756>

    same here etc.



protocols/gadu/gaduaccount.cpp (line 321)
<https://git.reviewboard.kde.org/r/130161/#comment68757>

    same here etc.



protocols/gadu/gaduaccount.cpp (line 1034)
<https://git.reviewboard.kde.org/r/130161/#comment68758>

    same here



protocols/gadu/gaduaccount.cpp (line 1077)
<https://git.reviewboard.kde.org/r/130161/#comment68759>

    same here



protocols/jabber/jabberformtranslator.cpp (line 23)
<https://git.reviewboard.kde.org/r/130161/#comment68760>

    Why ? why rename include file ?



protocols/jabber/jingle/jinglecontentdialog.cpp (line 20)
<https://git.reviewboard.kde.org/r/130161/#comment68761>

    same here



protocols/jabber/ui/dlgahcommand.cpp (line 22)
<https://git.reviewboard.kde.org/r/130161/#comment68762>

    same here...



protocols/yahoo/libkyahoo/alivetask.cpp 
<https://git.reviewboard.kde.org/r/130161/#comment68763>

    you removed all debug ?



protocols/yahoo/libkyahoo/receivefiletask.cpp 
<https://git.reviewboard.kde.org/r/130161/#comment68764>

    Why removed all debug ?



protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp (line 22)
<https://git.reviewboard.kde.org/r/130161/#comment68765>

    why renamed it ?


- Laurent Montel


On June 18, 2017, 2:09 p.m., Paulo Lieuthier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130161/
> -----------------------------------------------------------
> 
> (Updated June 18, 2017, 2:09 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> This was done mostly using regex, and now KDebug is no longer needed to link the protocols.
> 
> Pull from here: https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging
> 
> 
> Diffs
> -----
> 
>   protocols/bonjour/CMakeLists.txt ebe86af6a 
>   protocols/bonjour/bonjouraccount.cpp 0ea32aca3 
>   protocols/bonjour/bonjouraddcontactpage.cpp 85156eca9 
>   protocols/bonjour/bonjourcontact.cpp 0bb91e703 
>   protocols/bonjour/bonjourcontactconnection.cpp 94f07a1e2 
>   protocols/bonjour/bonjoureditaccountwidget.cpp 50d420204 
>   protocols/bonjour/bonjourprotocol.cpp fb265f2af 
>   protocols/gadu/CMakeLists.txt 4734b6258 
>   protocols/gadu/gaduaccount.cpp 830016eb1 
>   protocols/gadu/gaduaddcontactpage.cpp 431c5c8af 
>   protocols/gadu/gaducommands.cpp 94d4b5bc7 
>   protocols/gadu/gaducontact.h cacc598c9 
>   protocols/gadu/gaducontact.cpp 3ebb270bb 
>   protocols/gadu/gaducontactlist.cpp e80025cce 
>   protocols/gadu/gadudcc.cpp 19bef1a4d 
>   protocols/gadu/gadudccserver.cpp 85d26b1aa 
>   protocols/gadu/gadudcctransaction.cpp 27d501867 
>   protocols/gadu/gadueditaccount.cpp 21e111545 
>   protocols/gadu/gadueditcontact.cpp 691acb1e6 
>   protocols/gadu/gaduprotocol.cpp 4c102f6a2 
>   protocols/gadu/gadupubdir.h 45761facd 
>   protocols/gadu/gadupubdir.cpp c73fa0741 
>   protocols/gadu/gaduregisteraccount.cpp 56cfca52a 
>   protocols/gadu/gadurichtextformat.cpp 1974dfe0c 
>   protocols/gadu/gadusession.cpp 4b9d02747 
>   protocols/groupwise/CMakeLists.txt 33f7e435e 
>   protocols/groupwise/gwaccount.cpp 43220e984 
>   protocols/groupwise/gwbytestream.cpp 0ae83090c 
>   protocols/groupwise/gwconnector.cpp 1677fe3bc 
>   protocols/groupwise/gwcontact.cpp 831af63c6 
>   protocols/groupwise/gwcontactlist.cpp a54773588 
>   protocols/groupwise/gwmessagemanager.cpp 9075a7014 
>   protocols/groupwise/gwprotocol.cpp 8251921f3 
>   protocols/groupwise/libgroupwise/CMakeLists.txt c36311fcd 
>   protocols/groupwise/libgroupwise/bytestream.cpp df0c711c3 
>   protocols/groupwise/libgroupwise/chatroommanager.cpp ff6ba0b59 
>   protocols/groupwise/libgroupwise/client.cpp 4cfa5dd04 
>   protocols/groupwise/libgroupwise/compress.cpp 1069db9c7 
>   protocols/groupwise/libgroupwise/compressionhandler.cpp ac2657bb8 
>   protocols/groupwise/libgroupwise/coreprotocol.cpp f2fbbf8c7 
>   protocols/groupwise/libgroupwise/gwerror.h 31d576902 
>   protocols/groupwise/libgroupwise/gwfield.cpp e88499a75 
>   protocols/groupwise/libgroupwise/inputprotocolbase.cpp b31a98a65 
>   protocols/groupwise/libgroupwise/rtf.cc 7c1ee8519 
>   protocols/groupwise/libgroupwise/rtf.ll 3b84a30c7 
>   protocols/groupwise/libgroupwise/rtf2html.h 53952c694 
>   protocols/groupwise/libgroupwise/tasks/chatcountstask.cpp 8a7f307fa 
>   protocols/groupwise/libgroupwise/tasks/chatpropertiestask.cpp 48c045c0e 
>   protocols/groupwise/libgroupwise/tasks/getchatsearchresultstask.cpp a6432353c 
>   protocols/groupwise/libgroupwise/tasks/logintask.cpp 756c662d6 
>   protocols/groupwise/libgroupwise/tasks/searchchattask.cpp f597721b4 
>   protocols/groupwise/libgroupwise/tasks/searchusertask.cpp 9f8614472 
>   protocols/groupwise/libgroupwise/tests/clientstream_test.cpp 24a07ecd9 
>   protocols/groupwise/libgroupwise/userdetailsmanager.cpp 2850c0d65 
>   protocols/groupwise/ui/gwaddcontactpage.cpp 2c1b8b084 
>   protocols/groupwise/ui/gwchatpropsdialog.cpp 138f38016 
>   protocols/groupwise/ui/gwchatsearchdialog.cpp c5719c8d6 
>   protocols/groupwise/ui/gwcontactproperties.cpp ed7ff4fa5 
>   protocols/groupwise/ui/gweditaccountwidget.cpp a48351383 
>   protocols/groupwise/ui/gwprivacydialog.cpp 8dd11f1ab 
>   protocols/groupwise/ui/gwsearch.cpp 50a15730d 
>   protocols/jabber/CMakeLists.txt 6ea47b82e 
>   protocols/jabber/jabberaccount.cpp 4829934b6 
>   protocols/jabber/jabberbasecontact.cpp 658875e05 
>   protocols/jabber/jabberbookmarks.cpp efe9e40d2 
>   protocols/jabber/jabbercapabilitiesmanager.cpp 4afc5489d 
>   protocols/jabber/jabberchatsession.cpp 0aa3c852d 
>   protocols/jabber/jabberclient.cpp 33c4873e2 
>   protocols/jabber/jabbercontact.cpp bc7794175 
>   protocols/jabber/jabbercontactpool.cpp e0ce7b0f1 
>   protocols/jabber/jabberfiletransfer.cpp db47cc701 
>   protocols/jabber/jabberformtranslator.cpp 7172fa794 
>   protocols/jabber/jabbergroupchatmanager.cpp 2347fd2da 
>   protocols/jabber/jabbergroupcontact.cpp 5f764bbad 
>   protocols/jabber/jabbergroupmembercontact.cpp 57ee80e38 
>   protocols/jabber/jabberprotocol.cpp e5dfecd1d 
>   protocols/jabber/jabberresource.cpp 0a5c34c0e 
>   protocols/jabber/jabberresourcepool.cpp 1619cce38 
>   protocols/jabber/jabbertransport.cpp e3a98e858 
>   protocols/jabber/jabberxdatawidget.cpp cb35854d9 
>   protocols/jabber/jingle/alsaio.cpp cfcb9538e 
>   protocols/jabber/jingle/jabberjinglecontent.cpp a831e9818 
>   protocols/jabber/jingle/jabberjinglesession.cpp ce0e6d121 
>   protocols/jabber/jingle/jinglecallsgui.cpp 0a28d0cd8 
>   protocols/jabber/jingle/jinglecallsmanager.cpp 42c044f70 
>   protocols/jabber/jingle/jinglecontentdialog.cpp 10637b80e 
>   protocols/jabber/jingle/jinglertpsession.cpp 7acc720ab 
>   protocols/jabber/jingle/mediamanager.cpp 205203462 
>   protocols/jabber/jingle/mediasession.cpp 3926a01c2 
>   protocols/jabber/jingle/speexio.cpp 7d5aad7ba 
>   protocols/jabber/kioslave/jabberdisco.cpp 44bb46ac7 
>   protocols/jabber/libiris/CMakeLists.txt f9ff6ada6 
>   protocols/jabber/libiris/src/irisnet/corelib/netnames.cpp 963f6c29b 
>   protocols/jabber/libiris/src/irisnet/noncore/cutestuff/bsocket.cpp bce9b52f0 
>   protocols/jabber/libiris/src/irisnet/noncore/cutestuff/socks.cpp d6ac04ae6 
>   protocols/jabber/libiris/src/xmpp/base/timezone.cpp e83447126 
>   protocols/jabber/libiris/src/xmpp/sasl/digestmd5response.cpp 2720fb7bd 
>   protocols/jabber/libiris/src/xmpp/sasl/scramsha1response.cpp 90c0af4aa 
>   protocols/jabber/libiris/src/xmpp/sasl/scramsha1signature.cpp e08e76f60 
>   protocols/jabber/libiris/src/xmpp/xmpp-core/compressionhandler.cpp 7876c9058 
>   protocols/jabber/libiris/src/xmpp/xmpp-core/connector.cpp 3dabede88 
>   protocols/jabber/libiris/src/xmpp/xmpp-core/protocol.cpp b7732580f 
>   protocols/jabber/libiris/src/xmpp/xmpp-core/simplesasl.cpp df1fccdae 
>   protocols/jabber/libiris/src/xmpp/xmpp-core/sm.cpp e50c1bdbd 
>   protocols/jabber/libiris/src/xmpp/xmpp-core/stream.cpp eb46f1e04 
>   protocols/jabber/libiris/src/xmpp/xmpp-im/client.cpp 73db7439a 
>   protocols/jabber/libiris/src/xmpp/xmpp-im/s5b.cpp 8d090f6a2 
>   protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_caps.cpp befdc2f27 
>   protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_discoitem.cpp dec859262 
>   protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_task.cpp 975009ac7 
>   protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_vcard.cpp ba89a2e41 
>   protocols/jabber/libiris/src/xmpp/zlib/zlibcompressor.cpp 6f2715321 
>   protocols/jabber/libiris/src/xmpp/zlib/zlibdecompressor.cpp 1d3aedbb9 
>   protocols/jabber/libjingle.cpp ffe01035a 
>   protocols/jabber/tasks/privacylist.cpp 87987bff0 
>   protocols/jabber/tasks/privacylistitem.cpp 69a1fb254 
>   protocols/jabber/tasks/privacymanager.cpp f7d6017f1 
>   protocols/jabber/ui/dlgahclist.cpp 7af1fc620 
>   protocols/jabber/ui/dlgahcommand.cpp c2476076c 
>   protocols/jabber/ui/dlgjabberchangepassword.cpp a6abfb6b8 
>   protocols/jabber/ui/dlgjabberchatjoin.cpp 5546abfe7 
>   protocols/jabber/ui/dlgjabberchatroomslist.cpp 656c31cab 
>   protocols/jabber/ui/dlgjabberservices.cpp 40b194dc6 
>   protocols/jabber/ui/dlgjabbervcard.cpp d27bb6b3b 
>   protocols/jabber/ui/dlgregister.cpp 193c2190f 
>   protocols/jabber/ui/dlgsearch.cpp 2ae256666 
>   protocols/jabber/ui/jabberchooseserver.cpp c430f4283 
>   protocols/jabber/ui/jabbereditaccountwidget.cpp 5da65eb8a 
>   protocols/jabber/ui/jabberregisteraccount.cpp 79c66f7e1 
>   protocols/jabber/ui/privacylistmodel.cpp c06f903e0 
>   protocols/jabber/xoauth2provider.cpp c1ad71cfc 
>   protocols/meanwhile/CMakeLists.txt 64681e2a6 
>   protocols/meanwhile/meanwhilecontact.cpp f2a11684f 
>   protocols/meanwhile/meanwhileeditaccountwidget.cpp 7eb06d15d 
>   protocols/meanwhile/meanwhileprotocol.h 645af444c 
>   protocols/oscar/CMakeLists.txt 9df89a093 
>   protocols/oscar/aim/CMakeLists.txt 126549dc8 
>   protocols/oscar/aim/aimaccount.cpp 9f4841ee8 
>   protocols/oscar/aim/aimcontact.cpp b851edd15 
>   protocols/oscar/aim/aimjoinchat.cpp 665167779 
>   protocols/oscar/aim/aimprotocol.cpp 4f48dbb46 
>   protocols/oscar/aim/aimuserinfo.cpp 7a1067243 
>   protocols/oscar/aim/icqcontact.cpp 436cc8bc8 
>   protocols/oscar/aim/ui/aimeditaccountwidget.cpp 060d62297 
>   protocols/oscar/aimcontactbase.cpp 710c7db92 
>   protocols/oscar/icq/CMakeLists.txt d3bce881e 
>   protocols/oscar/icq/aimcontact.cpp c904f9519 
>   protocols/oscar/icq/icqaccount.cpp 6e3e6191e 
>   protocols/oscar/icq/icqcontact.cpp cbd5c77a8 
>   protocols/oscar/icq/icqprotocol.cpp 4b8e3501f 
>   protocols/oscar/icq/icqreadaway.h 1b06582ce 
>   protocols/oscar/icq/ui/editorwithicon.cpp 4b87b0cd8 
>   protocols/oscar/icq/ui/icqaddcontactpage.cpp 82cc33226 
>   protocols/oscar/icq/ui/icqchangepassworddialog.cpp eb0e01665 
>   protocols/oscar/icq/ui/icqeditaccountwidget.cpp f152aefd7 
>   protocols/oscar/icq/ui/icqsearchdialog.cpp f1b396c21 
>   protocols/oscar/icq/ui/icquserinfowidget.cpp f37ff6492 
>   protocols/oscar/icq/ui/xtrazicqstatusdialog.cpp 3b1ae6420 
>   protocols/oscar/liboscar/CMakeLists.txt 6e662bee4 
>   protocols/oscar/liboscar/buffer.cpp caeab676b 
>   protocols/oscar/liboscar/client.cpp 147b8ca1f 
>   protocols/oscar/liboscar/connection.cpp 694ae415b 
>   protocols/oscar/liboscar/connectionhandler.cpp 9a5db1033 
>   protocols/oscar/liboscar/contact.cpp 851b3e3bb 
>   protocols/oscar/liboscar/contactmanager.cpp b42859546 
>   protocols/oscar/liboscar/coreprotocol.cpp 797773c4b 
>   protocols/oscar/liboscar/flapprotocol.cpp 4ac35ca34 
>   protocols/oscar/liboscar/icquserinfo.cpp 4a10c8642 
>   protocols/oscar/liboscar/inputprotocolbase.cpp e8f0d359d 
>   protocols/oscar/liboscar/oftmetatransfer.cpp beba61459 
>   protocols/oscar/liboscar/oftprotocol.cpp 619af87cd 
>   protocols/oscar/liboscar/ofttransfer.cpp 8404b83cf 
>   protocols/oscar/liboscar/oscarclientstream.cpp 87d578ca9 
>   protocols/oscar/liboscar/oscarmessageplugin.cpp 69fe599c2 
>   protocols/oscar/liboscar/oscartypeclasses.cpp 4cf833138 
>   protocols/oscar/liboscar/oscarutils.cpp 5115197a4 
>   protocols/oscar/liboscar/rateclass.cpp 2e7541064 
>   protocols/oscar/liboscar/rateclassmanager.cpp c805d9fd8 
>   protocols/oscar/liboscar/snacprotocol.cpp f32153201 
>   protocols/oscar/liboscar/tasks/blmlimitstask.cpp 3d3a66204 
>   protocols/oscar/liboscar/tasks/buddyicontask.cpp 2ec132ee2 
>   protocols/oscar/liboscar/tasks/chatnavservicetask.cpp 0f776c93f 
>   protocols/oscar/liboscar/tasks/chatroomtask.cpp 8e8b44947 
>   protocols/oscar/liboscar/tasks/chatservicetask.cpp 150edc4f2 
>   protocols/oscar/liboscar/tasks/clientreadytask.cpp 37bdc4c7c 
>   protocols/oscar/liboscar/tasks/closeconnectiontask.cpp 780efbcd1 
>   protocols/oscar/liboscar/tasks/errortask.cpp 3680d8896 
>   protocols/oscar/liboscar/tasks/filetransfertask.cpp bea6f56f0 
>   protocols/oscar/liboscar/tasks/icbmparamstask.cpp a272f31d3 
>   protocols/oscar/liboscar/tasks/icqchangepasswordtask.cpp 15987afc2 
>   protocols/oscar/liboscar/tasks/icqtask.cpp 9a60bc56a 
>   protocols/oscar/liboscar/tasks/icqtlvinforequesttask.cpp f5925857a 
>   protocols/oscar/liboscar/tasks/icqtlvinfoupdatetask.cpp 519253442 
>   protocols/oscar/liboscar/tasks/icquserinfotask.cpp 5fca60b08 
>   protocols/oscar/liboscar/tasks/icquserinfoupdatetask.cpp 44a8ad2ef 
>   protocols/oscar/liboscar/tasks/locationrightstask.cpp 782ebd4ce 
>   protocols/oscar/liboscar/tasks/logintask.cpp b66e74a17 
>   protocols/oscar/liboscar/tasks/messagereceivertask.cpp ac1498d42 
>   protocols/oscar/liboscar/tasks/offlinemessagestask.cpp 7e9ce8b73 
>   protocols/oscar/liboscar/tasks/onlinenotifiertask.cpp 4fbe9235d 
>   protocols/oscar/liboscar/tasks/oscarlogintask.cpp 76048367d 
>   protocols/oscar/liboscar/tasks/ownuserinfotask.cpp 34ae55b70 
>   protocols/oscar/liboscar/tasks/prmparamstask.cpp da5bd5b64 
>   protocols/oscar/liboscar/tasks/profiletask.cpp df24ff9af 
>   protocols/oscar/liboscar/tasks/rateinfotask.cpp 0fe261ede 
>   protocols/oscar/liboscar/tasks/senddcinfotask.cpp 662fd1441 
>   protocols/oscar/liboscar/tasks/sendidletimetask.cpp 3f3ed407d 
>   protocols/oscar/liboscar/tasks/sendmessagetask.cpp 6280659bc 
>   protocols/oscar/liboscar/tasks/serverredirecttask.cpp aa9617fb1 
>   protocols/oscar/liboscar/tasks/serverversionstask.cpp 9e5f172b6 
>   protocols/oscar/liboscar/tasks/servicesetuptask.cpp 62651e7b8 
>   protocols/oscar/liboscar/tasks/ssiactivatetask.cpp 08192bee4 
>   protocols/oscar/liboscar/tasks/ssiauthtask.cpp 469e54567 
>   protocols/oscar/liboscar/tasks/ssilisttask.cpp a4bdaab7d 
>   protocols/oscar/liboscar/tasks/ssimodifytask.cpp 31fe73e81 
>   protocols/oscar/liboscar/tasks/ssiparamstask.cpp 3bb61d87e 
>   protocols/oscar/liboscar/tasks/task.cpp 68e0d98d7 
>   protocols/oscar/liboscar/tasks/typingnotifytask.cpp 616d5c169 
>   protocols/oscar/liboscar/tasks/userinfotask.cpp 1241b0294 
>   protocols/oscar/liboscar/tasks/warningtask.cpp d88300a27 
>   protocols/oscar/liboscar/tests/logintest.cpp 1a62726af 
>   protocols/oscar/liboscar/transfer.cpp 6ddad68a9 
>   protocols/oscar/liboscar/userdetails.cpp c043ec979 
>   protocols/oscar/liboscar/utils/rtf.cc 9110477d0 
>   protocols/oscar/liboscar/utils/rtf.ll d82e8aadb 
>   protocols/oscar/liboscar/utils/rtf2html.h a305b89d7 
>   protocols/oscar/liboscar/xtrazxtraznotify.cpp 18fdcb72b 
>   protocols/oscar/oscaraccount.cpp 3c4c707d9 
>   protocols/oscar/oscarcontact.cpp 6094fdc89 
>   protocols/oscar/oscarencodingselectiondialog.cpp 8dcfcc5a7 
>   protocols/oscar/oscarmyselfcontact.cpp e8fd0ac4f 
>   protocols/oscar/oscarprotocol.cpp ce1fdd950 
>   protocols/oscar/oscarstatusmanager.cpp 584cbbaf2 
>   protocols/oscar/oscarversionupdater.cpp a32bd1d38 
>   protocols/qq/CMakeLists.txt 19a89dcea 
>   protocols/qq/qqaccount.cpp 9ed930839 
>   protocols/qq/qqaddcontactpage.cpp 5fa693c7b 
>   protocols/qq/qqchatsession.cpp 015c9e9d0 
>   protocols/qq/qqcontact.cpp 271e44b63 
>   protocols/qq/qqnotifysocket.cpp c03027fa4 
>   protocols/qq/qqprotocol.cpp fba71ea59 
>   protocols/qq/qqsocket.cpp 7462b005c 
>   protocols/qq/ui/dlgqqvcard.cpp ab9dc6bd7 
>   protocols/qq/ui/qqeditaccountwidget.cpp ab6610505 
>   protocols/qq/ui/qqwebcamdialog.cpp 7bb30ac05 
>   protocols/skype/CMakeLists.txt 78c349efc 
>   protocols/skype/libskype/skype.cpp 2326c1ee8 
>   protocols/skype/libskype/skypedbus/skypeconnection.cpp ccca5414a 
>   protocols/skype/libskype/skypewindow.cpp 5a39e6a49 
>   protocols/skype/skypeaccount.cpp 0a8cd2031 
>   protocols/skype/skypeaddcontact.cpp 37c4fea16 
>   protocols/skype/skypebuttons/qtbrowserplugin/qtbrowserplugin_mac.cpp ec7e8d34f 
>   protocols/skype/skypecalldialog.cpp 078fd0ba6 
>   protocols/skype/skypechatsession.cpp db932184f 
>   protocols/skype/skypeconference.cpp 1f3f3fb40 
>   protocols/skype/skypecontact.cpp 8c78af5df 
>   protocols/skype/skypedetails.cpp cf43953cc 
>   protocols/skype/skypeeditaccount.cpp ee417f4b3 
>   protocols/skype/skypeprotocol.cpp 3db22b3ba 
>   protocols/sms/CMakeLists.txt 34e9f67d0 
>   protocols/sms/serviceloader.cpp d580c2b7d 
>   protocols/sms/services/gsmlib.cpp 95a537449 
>   protocols/sms/services/smsclient.cpp 09a29efbe 
>   protocols/sms/services/smssend.cpp 9cb939c5e 
>   protocols/sms/services/smssendprovider.cpp 1ff3a9ee7 
>   protocols/sms/smsaccount.cpp 648a787d0 
>   protocols/sms/smscontact.cpp 9645b73b8 
>   protocols/sms/smsprotocol.cpp 89a9e4d26 
>   protocols/sms/smsservice.cpp c3ed9c06d 
>   protocols/testbed/CMakeLists.txt c897637f0 
>   protocols/testbed/testbedaccount.cpp fcf1678b9 
>   protocols/testbed/testbedaddcontactpage.cpp 1d9247ef1 
>   protocols/testbed/testbedcontact.cpp 7c952dc9a 
>   protocols/testbed/testbededitaccountwidget.cpp 6793e3d88 
>   protocols/testbed/testbedfakeserver.cpp bbbc93741 
>   protocols/testbed/testbedprotocol.cpp 7df2c6c12 
>   protocols/testbed/ui/testbedwebcamdialog.cpp 3adab2d7a 
>   protocols/winpopup/CMakeLists.txt a03cee623 
>   protocols/winpopup/libwinpopup/libwinpopup.cpp 9a382ca69 
>   protocols/winpopup/wpaccount.cpp 716d0a218 
>   protocols/winpopup/wpaddcontact.cpp cc97e218e 
>   protocols/winpopup/wpcontact.cpp d946bf9e1 
>   protocols/winpopup/wpeditaccount.cpp 496d95071 
>   protocols/winpopup/wpprotocol.cpp 64f831bdf 
>   protocols/winpopup/wpuserinfo.cpp d24fe987e 
>   protocols/wlm/CMakeLists.txt 578447256 
>   protocols/wlm/ui/wlmaddcontactpage.cpp 10d80a641 
>   protocols/wlm/ui/wlmeditaccountwidget.cpp 2feb9cfa1 
>   protocols/wlm/wlmaccount.cpp 610201589 
>   protocols/wlm/wlmchatmanager.cpp 588ca524e 
>   protocols/wlm/wlmchatsession.cpp fa4bb0122 
>   protocols/wlm/wlmcontact.cpp c5890ba93 
>   protocols/wlm/wlmlibmsn.cpp 0cfc79a65 
>   protocols/wlm/wlmprotocol.cpp 6146ffd12 
>   protocols/wlm/wlmtransfermanager.cpp 05dd62370 
>   protocols/yahoo/CMakeLists.txt 73f526d2b 
>   protocols/yahoo/libkyahoo/CMakeLists.txt 088f2af25 
>   protocols/yahoo/libkyahoo/alivetask.cpp f6f2320bb 
>   protocols/yahoo/libkyahoo/bytestream.cpp 97c4bc79c 
>   protocols/yahoo/libkyahoo/changestatustask.cpp 8f041864f 
>   protocols/yahoo/libkyahoo/chatsessiontask.cpp 2589eed4f 
>   protocols/yahoo/libkyahoo/client.cpp 477df7b0d 
>   protocols/yahoo/libkyahoo/conferencetask.cpp 3e144b91d 
>   protocols/yahoo/libkyahoo/coreprotocol.cpp acd8e37d8 
>   protocols/yahoo/libkyahoo/filetransfernotifiertask.cpp 7435ea83e 
>   protocols/yahoo/libkyahoo/inputprotocolbase.cpp 230397fe4 
>   protocols/yahoo/libkyahoo/listtask.cpp 7c1e63c46 
>   protocols/yahoo/libkyahoo/logintask.cpp 27b44e2f5 
>   protocols/yahoo/libkyahoo/logofftask.cpp 9b221be70 
>   protocols/yahoo/libkyahoo/mailnotifiertask.cpp 5c36ed215 
>   protocols/yahoo/libkyahoo/messagereceivertask.cpp 70aaa6cce 
>   protocols/yahoo/libkyahoo/modifybuddytask.cpp dbb1854ca 
>   protocols/yahoo/libkyahoo/modifyyabtask.cpp 4f8c13c4d 
>   protocols/yahoo/libkyahoo/picturenotifiertask.cpp a8eaa4300 
>   protocols/yahoo/libkyahoo/pingtask.cpp e0553374a 
>   protocols/yahoo/libkyahoo/receivefiletask.cpp 62d575e3c 
>   protocols/yahoo/libkyahoo/requestpicturetask.cpp 0629e4fc8 
>   protocols/yahoo/libkyahoo/sendauthresptask.cpp 3ca3ee8e7 
>   protocols/yahoo/libkyahoo/sendfiletask.cpp 072d7fcd8 
>   protocols/yahoo/libkyahoo/sendmessagetask.cpp ced6ddc65 
>   protocols/yahoo/libkyahoo/sendnotifytask.cpp 28e98dc5f 
>   protocols/yahoo/libkyahoo/sendpicturetask.cpp dbe187ffe 
>   protocols/yahoo/libkyahoo/statusnotifiertask.cpp 4a1a6dde1 
>   protocols/yahoo/libkyahoo/stealthtask.cpp 1949ba6c6 
>   protocols/yahoo/libkyahoo/task.cpp 000a96954 
>   protocols/yahoo/libkyahoo/tests/CMakeLists.txt d216286dd 
>   protocols/yahoo/libkyahoo/tests/clientstream_test.cpp faf189e6c 
>   protocols/yahoo/libkyahoo/tests/logintest.cpp aab3621de 
>   protocols/yahoo/libkyahoo/webcamimgformat.cpp 4b53b694c 
>   protocols/yahoo/libkyahoo/webcamtask.cpp 4a1696234 
>   protocols/yahoo/libkyahoo/yabentry.cpp a0001c0d5 
>   protocols/yahoo/libkyahoo/yabtask.cpp c61ca7b25 
>   protocols/yahoo/libkyahoo/yahoobuddyiconloader.cpp 37336dd97 
>   protocols/yahoo/libkyahoo/yahoobytestream.cpp b7ed47215 
>   protocols/yahoo/libkyahoo/yahoochattask.cpp 7db64054c 
>   protocols/yahoo/libkyahoo/yahooclientstream.cpp 4b46fb645 
>   protocols/yahoo/libkyahoo/yahooconnector.cpp d8e5c36ff 
>   protocols/yahoo/libkyahoo/ymsgprotocol.cpp 62780482f 
>   protocols/yahoo/libkyahoo/ymsgtransfer.cpp f4fdb17f3 
>   protocols/yahoo/ui/yahoochatselectordialog.cpp ca0e6767b 
>   protocols/yahoo/ui/yahooinvitelistimpl.cpp c94de56b3 
>   protocols/yahoo/ui/yahoouserinfodialog.cpp e56403b91 
>   protocols/yahoo/ui/yahoowebcamdialog.cpp 69e7123dc 
>   protocols/yahoo/yahooaccount.cpp b7d110775 
>   protocols/yahoo/yahooaddcontact.cpp d3d6b13d1 
>   protocols/yahoo/yahoochatchatsession.cpp b5d7288b8 
>   protocols/yahoo/yahoochatsession.cpp 17c93c739 
>   protocols/yahoo/yahooconferencemessagemanager.cpp a6d853679 
>   protocols/yahoo/yahoocontact.cpp 720abbbd5 
>   protocols/yahoo/yahooeditaccount.cpp c51273623 
>   protocols/yahoo/yahooprotocol.cpp 6f2f6a8db 
>   protocols/yahoo/yahooverifyaccount.cpp aba1783e4 
>   protocols/yahoo/yahoowebcam.cpp c60f3cf63 
> 
> Diff: https://git.reviewboard.kde.org/r/130161/diff/
> 
> 
> Testing
> -------
> 
> Testbed account and test user creation and simple conversation. Only logging was changed.
> 
> 
> Thanks,
> 
> Paulo Lieuthier
> 
>