Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup
Vijay Krishnavanshi <[email protected]> Tue, 20 Jun 2017 11:11:20 -0000
| Newsgroups | gmane.comp.kde.devel.kopete |
|---|---|
| Message-ID | <[email protected]> |
> On June 18, 2017, 4:42 a.m., Laurent Montel wrote: > > tests/libkopete/kopetestatustest.cpp, line 46 > > <https://git.reviewboard.kde.org/r/130155/diff/3/?file=496304#file496304line46> > > > > now you can test 2 signal etc. > > > > Perhaps emit signal when same message etc. > > > > you need to create more autotests which is more complex. > > > > Regards I am working on the more complicated autotests. Is the current one okay? I will create even more complex autotests. - Vijay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130155/#review103334 ----------------------------------------------------------- On June 20, 2017, 11:08 a.m., Vijay Krishnavanshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130155/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 11:08 a.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > These autotests cover following classes - > - Kopete::PropertyTemplate > - Kopete::StatusGroup > - Kopete::Status::Status > - Kopete::PropertyContainer > - Kopete::Property > > > Diffs > ----- > > tests/libkopete/CMakeLists.txt 236284b > tests/libkopete/kopetepropertycontainertest.cpp PRE-CREATION > tests/libkopete/kopetepropertytemplatetest.cpp PRE-CREATION > tests/libkopete/kopetepropertytest.cpp PRE-CREATION > tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION > tests/libkopete/kopetestatustest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/130155/diff/ > > > Testing > ------- > > > Thanks, > > Vijay Krishnavanshi > >