Re: Review Request 124721: Adapt CMakeLists.txt to kf5

> On Sept. 30, 2017, 11:40 p.m., Luigi Toscano wrote:
> > Can this be dropped? The kf5 branch is way more updated.
> > 
> > @rharishnavnit (and all the others), can you please recheck which of your patches are outdated and can be dropped (because already applied or not relevant anymore)?

The KF5 branch might be way more updated but it needs a through review before merging to master. I understand porting work was carried on during this year's Google Summer of Code and I'm not sure if this was fixed during the same. I haven't been following the updates lately, sorry.


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review103753
-----------------------------------------------------------


On Aug. 13, 2015, 1:49 a.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 1:49 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   kopete/addaccountwizard/CMakeLists.txt e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 4444d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
>   plugins/statistics/CMakeLists.txt a4bb8dcea0b45d4f0918acbf51a082e17f386001 
>   plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 
>   plugins/texteffect/icons/CMakeLists.txt 5e7073f2f27421daf5782028ae6e3580e6e1793e 
>   plugins/translator/CMakeLists.txt 2df6e22ba63e11cdbb5ab8ec98da4876686d1144 
>   plugins/urlpicpreview/CMakeLists.txt 9fa72ea53bbb7b679bbe5970df8c17a6c3b3f734 
>   plugins/webpresence/CMakeLists.txt d5c0ebd5d38b9feefb19eb860f76db10c11eb2b2 
>   protocols/bonjour/CMakeLists.txt c7acede530d5a3e7f963d4712defef9bf0fd85f3 
>   protocols/bonjour/icons/CMakeLists.txt 5c80f4680e6baa5cc7b2e9c7b6761cf752da9d1d 
>   protocols/gadu/CMakeLists.txt b6da7736c94a1174b507aac3055b88c76da6aec2 
>   protocols/gadu/icons/CMakeLists.txt 5a4021207f802e546d1c4cc44efb0292e875ec2f 
>   protocols/groupwise/CMakeLists.txt 936e9be09131ec93da3aec27ffe0e45f1625a523 
>   protocols/groupwise/icons/CMakeLists.txt 5a4021207f802e546d1c4cc44efb0292e875ec2f 
>   protocols/groupwise/libgroupwise/CMakeLists.txt 45d0859863e2e0d34ccc0106902c9b74a240b8aa 
>   protocols/groupwise/libgroupwise/tasks/tests/CMakeLists.txt 44be324d3a283ff4bde27a994338b9891bfaca2e 
>   protocols/groupwise/libgroupwise/tests/CMakeLists.txt a7272c40f6560febe8d33cc3c192578e3ce893b1 
>   protocols/irc/CMakeLists.txt 645a67afbb7a9cf48b349904507501ade3e325f8 
>   protocols/irc/icons/CMakeLists.txt 5a4021207f802e546d1c4cc44efb0292e875ec2f 
>   protocols/irc/libkirc/CMakeLists.txt 68738803ae66480f49b9b8f98341805828070f14 
>   protocols/irc/libkirc/client/CMakeLists.txt 4dc93408bb70b89dce77d5680c8a6de1ce70ecbe 
>   protocols/jabber/CMakeLists.txt b8c0f9ead40f370a5231fc3efbf17f45c008afeb 
>   protocols/jabber/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   protocols/jabber/kioslave/CMakeLists.txt a6155c382708b60dbb8eb4af28d70408cc3e6001 
>   protocols/jabber/libiris/CMakeLists.txt c0b7dc29150e1c9a9c581d54e0158d8c8853095d 
>   protocols/jabber/libiris/src/jdns/src/qjdns/CMakeLists.txt ef464bb6dbfa4c616cb91cec895fd51021f56c01 
>   protocols/jabber/libiris/src/jdns/tools/jdns/CMakeLists.txt 89cadbc3503eaaff43e67e421d301ea6f4ad9dac 
>   protocols/meanwhile/CMakeLists.txt 8cc44e06ab7878bdc9ef5b278c01a862129f9a69 
>   protocols/meanwhile/icons/CMakeLists.txt 5a4021207f802e546d1c4cc44efb0292e875ec2f 
>   protocols/oscar/CMakeLists.txt e75b15b58fc9f412699d74c58518d4b51b5abd46 
>   protocols/oscar/aim/CMakeLists.txt 4828fac179c316c5597249f94dbf129309b02521 
>   protocols/oscar/icons/CMakeLists.txt 5a4021207f802e546d1c4cc44efb0292e875ec2f 
>   protocols/oscar/icq/CMakeLists.txt c1702b222f54d04fd92da997e7db04f3ea1171ad 
>   protocols/oscar/liboscar/CMakeLists.txt 37107a99770cc6076f0db693358b4455607c375b 
>   protocols/oscar/liboscar/tests/CMakeLists.txt c3a27375fb6cb11a0e673302e0ef39b22581517f 
>   protocols/qq/CMakeLists.txt 00640b2d33160ea5dab9499afda89f91d5586ea8 
>   protocols/qq/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   protocols/skype/CMakeLists.txt 5b72c63919841c4155e7b24aa896d08feca7e8c0 
>   protocols/skype/icons/CMakeLists.txt ae0931e49a0311fbe1506410737a07bb111b1253 
>   protocols/skype/skypebuttons/CMakeLists.txt 3d4a170639c93f25fbff90dcd6dfb1370f3e7e69 
>   protocols/sms/CMakeLists.txt b02eba52574597cb42ff024e11ad577979a61c24 
>   protocols/sms/icons/CMakeLists.txt 323c5389f0f86e63f5df85a2f4698fdcf0399879 
>   protocols/sms/services/CMakeLists.txt 4371ef2b03ce821a2c34c97758486fb0643c08c7 
>   protocols/sms/ui/CMakeLists.txt 08653cc32a5e10fd112361ec0121a27298f93969 
>   protocols/testbed/CMakeLists.txt 274e3c2fac7dc1279f141d77992d45bb6ce9d00a 
>   protocols/testbed/icons/CMakeLists.txt 6ab5790c03dd38b79d72607dceb1818911e41e9f 
>   protocols/winpopup/CMakeLists.txt 1f1f18db41bab80f3150f5551373958e8a623127 
>   protocols/winpopup/icons/CMakeLists.txt 323c5389f0f86e63f5df85a2f4698fdcf0399879 
>   protocols/wlm/CMakeLists.txt 8a5693398163f6d590a693b3f833aa05bd54f916 
>   protocols/wlm/icons/CMakeLists.txt fa795ac2ab22e63163c31b0de08da2d8cb8f70c2 
>   protocols/yahoo/CMakeLists.txt d607eaa110e4035e43d4c8167a88c0f0cc7ed640 
>   protocols/yahoo/icons/CMakeLists.txt 6ab5790c03dd38b79d72607dceb1818911e41e9f 
>   protocols/yahoo/libkyahoo/CMakeLists.txt 9a08ed682fd1fccaf31805888914b2eb3307c29a 
>   protocols/yahoo/libkyahoo/tests/CMakeLists.txt 77c4bbd538704656cddeb49fba3c974f9b82b3e9 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/124721/diff/1/
> 
> 
> Testing
> -------
> 
> cmake build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>