D12530: Remove the WLM protocol

Pino Toscano <[email protected]> Thu, 26 Apr 2018 05:03:08 +0000
Newsgroups	gmane.comp.kde.devel.kopete
Message-ID	<[email protected]>
--b2a15a67bbc24e7a84dce8c1e145f233
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

pino created this revision.
pino added reviewers: dfaure, kde-i18n-doc.
Restricted Application added a project: Kopete.
Restricted Application added subscribers: kde-doc-english, Kopete.
pino requested review of this revision.

REVISION SUMMARY
  Microsoft discontinued the Windows Live Messenger service in 2013, so
  this protocol is effectively dead.
  
  As a result:
  
  - remove the code of the protocol itself
  - remove all the supporting cmake stuff
  - remove one notification specific to it
  - slightly update the documentation to not mention WLM anymore
  
  This way, developers/downstreams will not try to accidentally build/ship
  this anymore.

TEST PLAN
  Builds fine

REPOSITORY
  R434 Kopete

BRANCH
  Applications/18.04

REVISION DETAIL
  https://phabricator.kde.org/D12530

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindLibmsn.cmake
  doc/index.docbook
  kopete/kopete.notifyrc
  protocols/CMakeLists.txt
  protocols/wlm/CMakeLists.txt
  protocols/wlm/README
  protocols/wlm/icons/CMakeLists.txt
  protocols/wlm/icons/ox128-app-wlm_protocol.png
  protocols/wlm/icons/ox16-action-wlm_away.png
  protocols/wlm/icons/ox16-action-wlm_blocked.png
  protocols/wlm/icons/ox16-action-wlm_brb.png
  protocols/wlm/icons/ox16-action-wlm_busy.png
  protocols/wlm/icons/ox16-action-wlm_fakefriend.png
  protocols/wlm/icons/ox16-action-wlm_invisible.png
  protocols/wlm/icons/ox16-action-wlm_lunch.png
  protocols/wlm/icons/ox16-action-wlm_na.png
  protocols/wlm/icons/ox16-action-wlm_newmsg.png
  protocols/wlm/icons/ox16-action-wlm_offline.png
  protocols/wlm/icons/ox16-action-wlm_online.png
  protocols/wlm/icons/ox16-action-wlm_phone.png
  protocols/wlm/icons/ox16-app-wlm_protocol.png
  protocols/wlm/icons/ox22-app-wlm_protocol.png
  protocols/wlm/icons/ox32-app-wlm_protocol.png
  protocols/wlm/icons/ox48-app-wlm_protocol.png
  protocols/wlm/icons/ox64-app-wlm_protocol.png
  protocols/wlm/icons/wlm_protocol.svgz
  protocols/wlm/kopete_wlm.desktop
  protocols/wlm/ui/wlmaccountpreferences.ui
  protocols/wlm/ui/wlmaddcontactpage.cpp
  protocols/wlm/ui/wlmaddcontactpage.h
  protocols/wlm/ui/wlmaddui.ui
  protocols/wlm/ui/wlmchatsessioninkpopup.ui
  protocols/wlm/ui/wlmeditaccountwidget.cpp
  protocols/wlm/ui/wlmeditaccountwidget.h
  protocols/wlm/ui/wlminfo.ui
  protocols/wlm/wlmaccount.cpp
  protocols/wlm/wlmaccount.h
  protocols/wlm/wlmchatmanager.cpp
  protocols/wlm/wlmchatmanager.h
  protocols/wlm/wlmchatsession.cpp
  protocols/wlm/wlmchatsession.h
  protocols/wlm/wlmchatsessioninkaction.cpp
  protocols/wlm/wlmchatsessioninkaction.h
  protocols/wlm/wlmchatsessioninkarea.cpp
  protocols/wlm/wlmchatsessioninkarea.h
  protocols/wlm/wlmchatui.rc
  protocols/wlm/wlmcontact.cpp
  protocols/wlm/wlmcontact.h
  protocols/wlm/wlmlibmsn.cpp
  protocols/wlm/wlmlibmsn.h
  protocols/wlm/wlmprotocol.cpp
  protocols/wlm/wlmprotocol.h
  protocols/wlm/wlmserver.cpp
  protocols/wlm/wlmserver.h
  protocols/wlm/wlmsocket.cpp
  protocols/wlm/wlmsocket.h
  protocols/wlm/wlmtransfermanager.cpp
  protocols/wlm/wlmtransfermanager.h

To: pino, dfaure, kde-i18n-doc
Cc: #kopete, kde-doc-english, himanshuvishwakarma, cochise

--b2a15a67bbc24e7a84dce8c1e145f233
Content-Transfer-Encoding: 7bit
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style="">pino created this revision.<br />pino added reviewers: dfaure, kde-i18n-doc.<br />Restricted Application added a project: Kopete.<br />Restricted Application added subscribers: kde-doc-english, Kopete.<br />pino requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12530">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Microsoft discontinued the Windows Live Messenger service in 2013, so<br />
this protocol is effectively dead.</p>

<p>As a result:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">remove the code of the protocol itself</li>
<li class="remarkup-list-item">remove all the supporting cmake stuff</li>
<li class="remarkup-list-item">remove one notification specific to it</li>
<li class="remarkup-list-item">slightly update the documentation to not mention WLM anymore</li>
</ul>

<p>This way, developers/downstreams will not try to accidentally build/ship<br />
this anymore.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Builds fine</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R434 Kopete</div></div></div><br /><div><strong>BRANCH</strong><div><div>Applications/18.04</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12530">https://phabricator.kde.org/D12530</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
cmake/modules/FindLibmsn.cmake<br />
doc/index.docbook<br />
kopete/kopete.notifyrc<br />
protocols/CMakeLists.txt<br />
protocols/wlm/CMakeLists.txt<br />
protocols/wlm/README<br />
protocols/wlm/icons/CMakeLists.txt<br />
protocols/wlm/icons/ox128-app-wlm_protocol.png<br />
protocols/wlm/icons/ox16-action-wlm_away.png<br />
protocols/wlm/icons/ox16-action-wlm_blocked.png<br />
protocols/wlm/icons/ox16-action-wlm_brb.png<br />
protocols/wlm/icons/ox16-action-wlm_busy.png<br />
protocols/wlm/icons/ox16-action-wlm_fakefriend.png<br />
protocols/wlm/icons/ox16-action-wlm_invisible.png<br />
protocols/wlm/icons/ox16-action-wlm_lunch.png<br />
protocols/wlm/icons/ox16-action-wlm_na.png<br />
protocols/wlm/icons/ox16-action-wlm_newmsg.png<br />
protocols/wlm/icons/ox16-action-wlm_offline.png<br />
protocols/wlm/icons/ox16-action-wlm_online.png<br />
protocols/wlm/icons/ox16-action-wlm_phone.png<br />
protocols/wlm/icons/ox16-app-wlm_protocol.png<br />
protocols/wlm/icons/ox22-app-wlm_protocol.png<br />
protocols/wlm/icons/ox32-app-wlm_protocol.png<br />
protocols/wlm/icons/ox48-app-wlm_protocol.png<br />
protocols/wlm/icons/ox64-app-wlm_protocol.png<br />
protocols/wlm/icons/wlm_protocol.svgz<br />
protocols/wlm/kopete_wlm.desktop<br />
protocols/wlm/ui/wlmaccountpreferences.ui<br />
protocols/wlm/ui/wlmaddcontactpage.cpp<br />
protocols/wlm/ui/wlmaddcontactpage.h<br />
protocols/wlm/ui/wlmaddui.ui<br />
protocols/wlm/ui/wlmchatsessioninkpopup.ui<br />
protocols/wlm/ui/wlmeditaccountwidget.cpp<br />
protocols/wlm/ui/wlmeditaccountwidget.h<br />
protocols/wlm/ui/wlminfo.ui<br />
protocols/wlm/wlmaccount.cpp<br />
protocols/wlm/wlmaccount.h<br />
protocols/wlm/wlmchatmanager.cpp<br />
protocols/wlm/wlmchatmanager.h<br />
protocols/wlm/wlmchatsession.cpp<br />
protocols/wlm/wlmchatsession.h<br />
protocols/wlm/wlmchatsessioninkaction.cpp<br />
protocols/wlm/wlmchatsessioninkaction.h<br />
protocols/wlm/wlmchatsessioninkarea.cpp<br />
protocols/wlm/wlmchatsessioninkarea.h<br />
protocols/wlm/wlmchatui.rc<br />
protocols/wlm/wlmcontact.cpp<br />
protocols/wlm/wlmcontact.h<br />
protocols/wlm/wlmlibmsn.cpp<br />
protocols/wlm/wlmlibmsn.h<br />
protocols/wlm/wlmprotocol.cpp<br />
protocols/wlm/wlmprotocol.h<br />
protocols/wlm/wlmserver.cpp<br />
protocols/wlm/wlmserver.h<br />
protocols/wlm/wlmsocket.cpp<br />
protocols/wlm/wlmsocket.h<br />
protocols/wlm/wlmtransfermanager.cpp<br />
protocols/wlm/wlmtransfermanager.h</div></div></div><br /><div><strong>To: </strong>pino, dfaure, kde-i18n-doc<br /><strong>Cc: </strong>Kopete, kde-doc-english, himanshuvishwakarma, cochise<br /></div>
--b2a15a67bbc24e7a84dce8c1e145f233--