D11845: Make clang happy.
Raphael Kubo da Costa <[email protected]> Sun, 29 Apr 2018 12:33:20 +0000
| Newsgroups | gmane.comp.kde.devel.kopete |
|---|---|
| Message-ID | <[email protected]> |
--8e652ab72e054f33a589bb1d5215a7b1
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
rakuco added inline comments.
INLINE COMMENTS
> chatnavservicetask.cpp:106
> FLAP f = { 0x02, 0, 0x00 };
> - SNAC s = { 0x000D, m_type, 0x0000, client()->snacSequence() };
> + SNAC s = { 0x000D, static_cast<WORD>(m_type), 0x0000, client()->snacSequence() };
> Buffer* b = new Buffer();
Alternatively, you can explicitly declare `RequestType`'s underlying integer type in the header:
enum RequestType : DWORD { ... };
REPOSITORY
R434 Kopete
REVISION DETAIL
https://phabricator.kde.org/D11845
To: tcberner, #freebsd, pali
Cc: rakuco, #kopete, himanshuvishwakarma, cochise
--8e652ab72e054f33a589bb1d5215a7b1
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
<table><tr><td style=3D"">rakuco added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D11845">View Revision</a></tr></table><br /=
><div><strong>INLINE COMMENTS</strong><div><div style=3D"margin: 6px 0 12px=
0;"><div style=3D"border: 1px solid #C7CCD9; border-radius: 3px;"><div sty=
le=3D"padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style:=
solid; border-width: 0 0 1px 0; margin: 0;"><div style=3D"color: #74777d; =
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style=3D"float=
: right; text-decoration: none;" href=3D"https://phabricator.kde.org/D11845=
#inline-64267">View Inline</a><span style=3D"color: #4b4d51; font-weight: b=
old;">chatnavservicetask.cpp:106</span></div>
<div style=3D"font: 11px/15px "Menlo", "Consolas", &quo=
t;Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px=
0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; "> <span cl=
ass=3D"n">FLAP</span> <span class=3D"n">f</span> <span style=3D"color: #aa2=
211">=3D</span> <span class=3D"p">{</span> <span style=3D"color: #601200">=
0x02</span><span class=3D"p">,</span> <span style=3D"color: #601200">0</spa=
n><span class=3D"p">,</span> <span style=3D"color: #601200">0x00</span> <sp=
an class=3D"p">};</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(251, 17=
5, 175, .7);"> <span class=3D"n">SNAC</span> <span class=3D"n">s</span> =
<span style=3D"color: #aa2211">=3D</span> <span class=3D"p">{</span> <span =
style=3D"color: #601200">0x000D</span><span class=3D"p">,</span> <span clas=
s=3D"n">m_type</span><span class=3D"p">,</span> <span style=3D"color: #6012=
00">0x0000</span><span class=3D"p">,</span> <span class=3D"n">client</span>=
<span class=3D"p">()</span><span style=3D"color: #aa2211">-></span><span=
class=3D"n">snacSequence</span><span class=3D"p">()</span> <span class=3D"=
p">};</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);"> <span class=3D"n">SNAC</span> <span class=3D"n">s</span> =
<span style=3D"color: #aa2211">=3D</span> <span class=3D"p">{</span> <span =
style=3D"color: #601200">0x000D</span><span class=3D"p">,</span> <span clas=
s=3D"bright"></span><span style=3D"color: #aa4000"><span class=3D"bright">s=
tatic_cast</span></span><span class=3D"bright"></span><span style=3D"color:=
#aa2211"><span class=3D"bright"><</span></span><span class=3D"bright"><=
/span><span class=3D"n"><span class=3D"bright">WORD</span></span><span clas=
s=3D"bright"></span><span style=3D"color: #aa2211"><span class=3D"bright">&=
gt;</span></span><span class=3D"bright"></span><span class=3D"p"><span clas=
s=3D"bright">(</span></span><span class=3D"n">m_type<span class=3D"bright">=
</span></span><span class=3D"bright"></span><span class=3D"p"><span class=
=3D"bright">)</span>,</span> <span style=3D"color: #601200">0x0000</span><s=
pan class=3D"p">,</span> <span class=3D"n">client</span><span class=3D"p">(=
)</span><span style=3D"color: #aa2211">-></span><span class=3D"n">snacSe=
quence</span><span class=3D"p">()</span> <span class=3D"p">};</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; "> <span class=3D"n">=
Buffer</span><span style=3D"color: #aa2211">*</span> <span class=3D"n">b</s=
pan> <span style=3D"color: #aa2211">=3D</span> <span style=3D"color: #aa400=
0">new</span> <span class=3D"n">Buffer</span><span class=3D"p">();</span>
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">Alternatively, you can explicitly declare <tt style=3D"background=
: #ebebeb; font-size: 13px;">RequestType</tt>'s underlying integer typ=
e in the header:</p>
<div class=3D"remarkup-code-block" style=3D"margin: 12px 0;" data-code-lang=
=3D"text" data-sigil=3D"remarkup-code-block"><pre class=3D"remarkup-code" s=
tyle=3D"font: 11px/15px "Menlo", "Consolas", "Mona=
co", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120=
, 0.08);">enum RequestType : DWORD { ... };</pre></div></div></div></div></=
div></div><br /><div><strong>REPOSITORY</strong><div><div>R434 Kopete</div>=
</div></div><br /><div><strong>REVISION DETAIL</strong><div><a href=3D"http=
s://phabricator.kde.org/D11845">https://phabricator.kde.org/D11845</a></div=
></div><br /><div><strong>To: </strong>tcberner, FreeBSD, pali<br /><strong=
>Cc: </strong>rakuco, Kopete, himanshuvishwakarma, cochise<br /></div>
--8e652ab72e054f33a589bb1d5215a7b1--