D14542: WIP: Basic KCM using new virtual desktops DBus interface
Eike Hein <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
hein added inline comments. INLINE COMMENTS > davidedmundson wrote in desktopsmodel.cpp:53 > We can just generate the interface from the XML and use the generated class instead of using low level classes. I have no preference here. Marco's patch currently doesn't provide an XML file, though. > davidedmundson wrote in desktopsmodel.cpp:361 > All this is already in the kwin repo for Marco's export. We should share code here even if it means including a C++ file from outside the kcmkwin dir. This was mentioned in the commit message, too. I want Marco to do this refactoring. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart