D14561: [kcmkwin/compositing] Rename Candy category to Eye Candy

Vlad Zagorodniy <[email protected]> Thu, 9 Aug 2018 12:47:52 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag abandoned this revision.
zzag added a comment.

  In D14561#305723 <https://phabricator.kde.org/D14561#305723>, @broulik wrote:

  > Wouldn't that break third party effects that have "Candy" in their manifest?

  Oh, yeah, you're right, it will "break" 3rd-party effects. :(

  > Perhaps only change the user-visible string?

  I'm afraid that by doing that we'll just add more mess to the code. E.g. desktopChanged(uint, uint) has been deprecated for many years and we still have it. So, there's a big chance that '// TODO: Rename to Eye Candy.' comments will be present for many years.

  Let's wait for KWin 6 and maybe then rename it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14561

To: zzag, #kwin, #plasma, #vdg, ngraham
Cc: broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart