D14749: WIP: [effects] Rewrite the Magic Lamp effect
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added reviewers: KWin, Plasma, VDG. Restricted Application added a project: KWin. Restricted Application added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY The current Magic lamp effect doesn't work correctly if a window is slightly below its icon in the task manager or when the panel is "between" screens(see bug 361121). Even though that's still WIP, the effect is pretty much usable right now. TODO: - explain the state machine(states/stages, transitions, etc); - pick good defaults; - revisit easing curves; - simplify code? (if it's possible); - write better commit message. That's not 5.14 stuff. Demos: - https://youtu.be/YTNlHn6axAA - https://youtu.be/GBT28mHz94M - https://youtu.be/V9WczTv_itQ - https://youtu.be/APCY_v9FLJE Sorry, for using YouTube, can't upload videos to Phabricator with file size > 2MB. BUG: 361121 REPOSITORY R108 KWin BRANCH rewrite-magic-lamp-effect REVISION DETAIL https://phabricator.kde.org/D14749 AFFECTED FILES effects/magiclamp/magiclamp.cpp effects/magiclamp/magiclamp.h To: zzag, #kwin, #plasma, #vdg Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart