D14728: [effects/minimizeanimation] Delete useless comments
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added a comment. Meh, I agree these add no value. But going out of your way to delete them when they're not wrong yet is equally of no value. Ship it if you want. I don't see the point. INLINE COMMENTS > minimizeanimation.h:30 > > -/** > - * Animates minimize/unminimize Being explicit that this also handles unminimise does add value. IMHO all of them could benefit from a one liner here saying what the effect is actually meant to do. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14728 To: zzag, #kwin Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart