D14862: [effects/slidingpopups] Overhaul slotPropertyNotify

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  - Improve slightly readability;
  - Check that offset and location have been passed;
  - Sanitize slide in/out duration (if any of those is equal to 0, KWin will crash).

TEST PLAN
  - Launched Yakuake;
  - Pressed F12 several times (Yakuake still slides in/out).

REPOSITORY
  R108 KWin

BRANCH
  effects-slidingpopups-validate-data-size

REVISION DETAIL
  https://phabricator.kde.org/D14862

AFFECTED FILES
  effects/slidingpopups/slidingpopups.cpp
  effects/slidingpopups/slidingpopups.h

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.