D14911: [effects/maximize] Make it work on Wayland

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  The Maximize effect doesn't work on Wayland because
  windowGeometryShapeChanged and windowMaximizedStateChanged are emitted
  in different order:
  
  for maximize:
  
  - windowGeometryShapeChanged
  - windowGeometryShapeChanged
  - windowMaximizedStateChanged
  - windowGeometryShapeChanged
  
  for restore:
  
  - windowGeometryShapeChanged
  - windowMaximizedStateChanged
  - windowGeometryShapeChanged
  
  We care only about window geometry in the last
  windowGeometryShapeChanged signal. Thus, we have to start the maximize
  animation only after the last windowGeometryShapeChanged signal has been
  emitted, not after windowMaximizedStateChanged.
  
  windowMaximizedStateChanged signal is used only to decide whether the
  proceeding windowGeometryShapeChanged signal will be the last.
  
  BUG: 384462

REPOSITORY
  R108 KWin

BRANCH
  effects-maximize-wayland

REVISION DETAIL
  https://phabricator.kde.org/D14911

AFFECTED FILES
  effects/maximize/package/contents/code/maximize.js
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart