D14536: [scripting] Port ScriptedEffects to QJSEngine

Vlad Zagorodniy <[email protected]> Mon, 20 Aug 2018 16:04:04 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added inline comments.

INLINE COMMENTS

> kwineffects.h:2177-2178
>      Q_SCRIPTABLE virtual KWin::EffectWindow* findModal() = 0;
> -    Q_SCRIPTABLE virtual QList<KWin::EffectWindow*> mainWindows() const = 0;
> +    Q_SCRIPTABLE QList<QObject*> mainWindows() const;
> +    virtual QList<KWin::EffectWindow*> mainEffectWindows() const = 0;
> +

We're breaking third-party effects, that's not good.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14536

To: davidedmundson, #kwin, mart, fvogt
Cc: fvogt, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart