D14783: [scenes/opengl] Correctly draw shadows when corner tiles are missing

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in scene_opengl.cpp:2246
> There's an interesting hypothetical here.
> 
> We're treating the null corners as rectangles at a single point, potentially if you had a large enough topleft shadow no topright corner you'll end up distributing it; and now our null image will get a valid rectangle.

That's pretty good catch. I'll fix it.

But, no, it [top-right corner rect] won't be valid, so it won't be rendered.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14783

To: zzag, #kwin
Cc: abetts, davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.