D15061: [xwl] Generic X selections translation mechanism with Clipboard support

romangg added a comment.


  In D15061#315063 <https://phabricator.kde.org/D15061#315063>, @graesslin wrote:
  
  > Just wondering: why did you integrate directly into KWin, instead of adding this to the existing helper process? My motivation to use a dedicated process was to ensure that KWin cannot be attacked through the X clipboard (the data is hold by the helper process, not by KWin).
  
  
  The patch is a preparation step for a not yet uploaded follow-up patch to allow Xwayland DND ( T4611 <https://phabricator.kde.org/T4611> ). For that I orientated myself on the implementation / WIP-patches of Weston and wlroots, that both have X Selections translation inside the compositor process. Xwayland DND is difficult already and the other projects don't have full support for it yet, so putting the generic X selections support out-of-process was just another complication I wanted to avoid for now. I personally also don't see a particular attack vector when having it in the compositor process. X clients and KWin communicate through the X protocol when exchanging X selections like they always do in a Wayland session with running Xwayland and data received is interpreted as raw bytes and only forwarded to clients on the Wayland side. If there is benefit to having it out-of-process, then I would reassess this in the future, maybe then combined with a move to put all X11 interfacing out of process in a Wayland session. For now I opt for not reusing the helper process in order to reduce the overall complexity and have as a starting point a mechanism akin to other compositor projects.
  
  > If you think having it in KWin is better I suggest a follow up change to move the normal clipboard functionality also into the xwl directory.
  
  Do you mean the X clipboard sync heper itself? It gets removed in follow-up patch D15063 <https://phabricator.kde.org/D15063>.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15061

To: romangg, #kwin
Cc: graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart