D15117: [RFC] [effects] Make Scale and Glide effects Wayland-friendly

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  The Scale effect and the Glide effect have to animate only ordinary
  windows(i.e. the ones that are considered to be apps).
  
  On X11, in order to distinguish ordinary windows from combo box popups,
  popup menus, and other popups, those effects check whether given window
  is managed.
  
  On Wayland, there is no concept of managed/unmanaged windows.
  
  XDG Shell protocol defines 2 surface roles:
  
  - xdg_toplevel;
  - and, xdg_popup.
  
  The former can be used to implement typical windows, the ones that can
  be minimized, maximized, etc.
  
  The latter can be used to implement tooltips, popup menus, etc. Thus,
  that's a good criteria to filter popup windows.

REPOSITORY
  R108 KWin

BRANCH
  effects-make-scale-and-glide-wayland-friendly

REVISION DETAIL
  https://phabricator.kde.org/D15117

AFFECTED FILES
  effects/glide/glide.cpp
  effects/scale/scale.cpp
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h
  shell_client.cpp
  shell_client.h
  toplevel.h

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart