D15117: [RFC] [effects] Make Scale and Glide effects Wayland-friendly
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added a comment. In D15117#316498 <https://phabricator.kde.org/D15117#316498>, @davidedmundson wrote: > Edit: I got distracted by window types and didn't mention isManaged. > > Effectively the documentation for isManaged is true for popups. > > /* Whether this EffectWindow is managed by KWin (it has control over its placement and other > * aspects*/ > > > technically kwin now does position it, but only within the constraints given to us by the application, so to all intents and purposes it doesn't. > > It could be introduces as a new property with a new name that wraps both isXdgPopup || isManaged > > But certainly I see no reason to expose isX11/isWayland/isTopLevel. So, what about adding `isPopupWindow` to EffectWindow? For Client, it will be the same as isManaged. For ShellClient, it will return `true` if it's a xdg_popup (or whether wl_shell_surface is a popup). REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D15117 To: zzag, #kwin Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart