D13887: use the new plasma virtual desktop protocol

davidedmundson added inline comments.

INLINE COMMENTS

> abstract_client.cpp:497
> +
> +    //can't check windowManagementInterface yet as it gets created only on first show
> +    //on x11 only one desktop at a time

check it for what?

> dbusinterface.cpp:378
> +
> +    new VirtualDesktopManagerAdaptor(this);
> +    QDBusConnection::sessionBus().registerObject(QStringLiteral("/VirtualDesktopManager"),

Why don't we have the adaptor directly on the VirtualDesktopManager?

The idea behind QDBusAbstractAdaptor is that they proxy all the signals/properties/slots from itself into the passed argument. We've come up with a manual layer of indirection which is just duplicating what VirtualDesktopManagerAdaptor does automatically.

If you do need to do mods or extra connects, you can subclass the VirtualDesktopManagerAdaptor rather than proxying.

> dbusinterface.cpp:453
> +
> +void VirtualDesktopManagerDBusInterface::setCount(uint count)
> +{

Do we want to expose setCount?

We have createDesktop/removeDesktop with IDs and names.
Having a version without that opens up a whole world of problems of desktops without IDs being out of sync.

Same for enterNewPlasmaVirtualDesktopRequested

> virtualdesktops.cpp:674
>      setCount(n);
> -    if (m_rootInfo) {
> -        for (int i = 1; i <= n; i++) {
> -            QString s = group.readEntry(QStringLiteral("Name_%1").arg(i), i18n("Desktop %1", i));
> +    //Use kactivitymanagerdrc directly?
> +

Eww, definitely not.

What I assumed we would do would be have kwin start up with 1VD. (ksplash is on all anyway)
Then kactivitymanagerd  (or even kcminit for the current mode) set everything on startup

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D13887

To: mart, #plasma, #kwin, graesslin, davidedmundson
Cc: hein, zzag, davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart