D13887: use the new plasma virtual desktop protocol
Marco Martin <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in abstract_client.cpp:497 > check it for what? ouch, old comments before operationMode was used to check > davidedmundson wrote in dbusinterface.cpp:378 > Why don't we have the adaptor directly on the VirtualDesktopManager? > > The idea behind QDBusAbstractAdaptor is that they proxy all the signals/properties/slots from itself into the passed argument. We've come up with a manual layer of indirection which is just duplicating what VirtualDesktopManagerAdaptor does automatically. > > If you do need to do mods or extra connects, you can subclass the VirtualDesktopManagerAdaptor rather than proxying. the problem would be the custom types DBusDesktopDataStruct, DBusDesktopDataVector, would them be defined in the VirtualDesktopManagerAdaptor subclass? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D13887 To: mart, #plasma, #kwin, graesslin, davidedmundson Cc: hein, zzag, davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart