D15175: [effects/cubeslide/wayland] Fix several cubeslide issues
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > poboiko wrote in cubeslide.cpp:525-532 > I thought about it initially, but I found out that it actually works fine - it blurs background on the moving cube face for non-sticky windows. > > Concerning m_forcedRoles - I added it so I can remove those roles afterwards. You're saying that I don't really have to do it? Yes, we don't need it. We'll force blur only for panels and sticky windows. Thus, m_forcedRoles will be redundant. > poboiko wrote in cubeslide.cpp:543 > Well, it also includes panels, but I can change it (probably, that semantics is even more obvious due to the context). Ok, let's leave it as it is. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D15175 To: poboiko, #kwin, zzag Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart