D15218: [effects/trackmouse] Use only shortcuts to toggle the effect

zzag created this revision.
zzag added reviewers: KWin, Plasma, VDG.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  Currently, the Track Mouse effect can be activated either by pressing a
  combination of modifiers(e.g. Ctrl + Meta) or by pressing a shortcut.
  
  302a245d0e00db4fe53c30b5b9717350a3493369 <https://phabricator.kde.org/R108:302a245d0e00db4fe53c30b5b9717350a3493369> introduced the shortcut
  feature. That "commit" didn't allow to change the shortcut unless all
  modifiers are unchecked, i.e. in order to set a shortcut you have to
  uncheck all modifiers.
  
  Somewhere along the way, "Modifiers" and "Shortcut" radio buttons had
  been added. With those radio buttons, users can now bypass previously
  mentioned constrains, making the Track Mouse effect a UX disaster.
  
  F6230452: Screenshot_20180902_151357.png <https://phabricator.kde.org/F6230452>
  
  We could uncheck modifiers when user selects the "Shortcut" radio
  button. The problem with this approach is that previous configuration
  gets lost.
  
  We could also store value of the "Modifiers" checkbox, for example, in
  the config, but I doubt it's worth the effort because at that point
  interaction with this effect would be broken. Why do we allow only
  either modifiers or shortcuts? Why not both of them?
  
  Another problem is that selected combination of modifiers can be a
  prefix of another shortcut.
  
  As the title says, this change drops support for activation of this
  effect with modifier keys.
  
  CCBUG: 398124

TEST PLAN
  F6230456: Screenshot_20180902_150324.png <https://phabricator.kde.org/F6230456>

REPOSITORY
  R108 KWin

BRANCH
  effects-trackmouse-drop-modifiers

REVISION DETAIL
  https://phabricator.kde.org/D15218

AFFECTED FILES
  effects/CMakeLists.txt
  effects/trackmouse/CMakeLists.txt
  effects/trackmouse/trackmouse.cpp
  effects/trackmouse/trackmouse.h
  effects/trackmouse/trackmouse.kcfg
  effects/trackmouse/trackmouse_config.cpp
  effects/trackmouse/trackmouse_config.h
  effects/trackmouse/trackmouse_config.ui
  effects/trackmouse/trackmouseconfig.kcfgc

To: zzag, #kwin, #plasma, #vdg
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart