D15218: [effects/trackmouse] Use only shortcuts to toggle the effect

zzag abandoned this revision.
zzag added a comment.


  > Is this actually desirable? If the presentation is currently bad, maybe we should work on that rather than removing features.
  > 
  > What would make sense to me is to have the shortcut chooser be the primary activation method, with a checkbox below it saying something like "Also trigger with modifier keys" that activates the existing modifier key UI.
  
  Well, I think we can have both activation with modifier keys and a shortcut. I'll implement it in another patch.
  
  > Then again I don't use this effect and doubt I ever will, so take my comments with a grain of salt. :)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15218

To: zzag, #kwin, #plasma, #vdg
Cc: ngraham, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart