D15272: [effects/trackmouse] Allow to use both modifiers and shortcut

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag created this revision.
zzag added reviewers: KWin, Plasma, VDG.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  The Track Mouse effect can be toggled either by pressing modifier keys
  and moving mouse or by pressing a shortcut. It's not possible to use
  the latter and then the former without changing config.
  
  But there is one caveat, in order to use shortcut, you have to uncheck
  all modifier keys. This seems to be not very intuitive.
  
  In addition to that, the KCM allows to change shortcut even if there is
  some checked modifier.
  
  As the title says, this change makes possible to use both modifier keys
  and shortcut to activate this effect.
  
  BUG: 398124
  FIXED-IN: 5.XX.X

REPOSITORY
  R108 KWin

BRANCH
  effects-trackmouse-shortcut

REVISION DETAIL
  https://phabricator.kde.org/D15272

AFFECTED FILES
  effects/trackmouse/trackmouse.cpp
  effects/trackmouse/trackmouse.h
  effects/trackmouse/trackmouse_config.cpp
  effects/trackmouse/trackmouse_config.h
  effects/trackmouse/trackmouse_config.ui

To: zzag, #kwin, #plasma, #vdg
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.