D15307: Remove Context Help button by default

ngraham created this revision.
ngraham added reviewers: KWin, VDG.
Herald added a project: KWin.
Herald added a subscriber: kwin.
ngraham requested review of this revision.

REVISION SUMMARY
  Sadly, today in 2018, the Context Help window decoration button is not very useful. Few KDE apps actually properly support the feature for mor than a tiny fraction of their UI, and no non-KDE apps do at all. So when you click on the button and mouse over various parts of an app's UI, you mostly see the red crossed our circle cursor. Not very useful.
  
  We had a conversation about this during the VDG BoF at this year's Akademy and there seemed to be general agreement that this window decoration button is not very useful anymore. So let's remove it from the default set of window decoration buttons.

TEST PLAN
  Apply patch, create new user account, log in as new user, open a window, notice no Context Help button

REPOSITORY
  R108 KWin

BRANCH
  remove-context-help-button-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15307

AFFECTED FILES
  kcmkwin/kwindecoration/kcm.cpp

To: ngraham, #kwin, #vdg
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart